Skip to content

Disable the selectivity of a text in video gallery for long touch to function properly #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prabhjot-msft merged 4 commits into from
Mar 2, 2023
Merged

Disable the selectivity of a text in video gallery for long touch to function properly #2790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e0888
disable the selectivity of a text in video gallery for long touch to …
prabhjot-msft Mar 1, 2023
02d950a
Change files
prabhjot-msft Mar 1, 2023
184d90c
Duplicate change files for beta release
prabhjot-msft Mar 1, 2023
ff6246a
Merge remote-tracking branch 'origin' into prabhjot/longpress-bug
prabhjot-msft Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change-beta/@azure-communication-react-b3573c06-f7c3-42a4-a963-9a49eeb23b0c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "disable the selectivity of a text in video gallery for long touch to function properly",
"packageName": "@azure/communication-react",
"email": "97124699+prabhjot-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@azure-communication-react-b3573c06-f7c3-42a4-a963-9a49eeb23b0c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "disable the selectivity of a text in video gallery for long touch to function properly",
"packageName": "@azure/communication-react",
"email": "97124699+prabhjot-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
14 changes: 13 additions & 1 deletion packages/react-components/src/components/VideoGallery.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,18 @@ import { useId } from '@fluentui/react-hooks';
* Currently the Calling JS SDK supports up to 4 remote video streams
*/
export const DEFAULT_MAX_REMOTE_VIDEO_STREAMS = 4;

/**
* @private
* Styles to disable the selectivity of a text in video gallery
*/
export const unselectable = {
'-webkit-user-select': 'none',
'-webkit-touch-callout': 'none',
'-moz-user-select': 'none',
'-ms-user-select': 'none',
'user-select': 'none'
};
/**
* @private
* Set aside only 6 dominant speakers for remaining audio participants
Expand Down Expand Up @@ -568,7 +580,7 @@ export const VideoGallery = (props: VideoGalleryProps): JSX.Element => {
id={drawerMenuHostIdFromProp ? undefined : drawerMenuHostId}
data-ui-id={ids.videoGallery}
ref={containerRef}
className={mergeStyles(videoGalleryOuterDivStyle, styles?.root)}
className={mergeStyles(videoGalleryOuterDivStyle, styles?.root, unselectable)}
>
{videoGalleryLayout}
{
Expand Down
⚡