Skip to content

[A11y bugfix] Allow voice controls to action people button in Call and CallWithChat #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmceachernmsft merged 4 commits into from
Mar 22, 2023
Merged

[A11y bugfix] Allow voice controls to action people button in Call and CallWithChat #2833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0838242
update aria strings for people button
dmceachernmsft Mar 22, 2023
8efe451
fix ???
dmceachernmsft Mar 22, 2023
e8466f3
Change files
dmceachernmsft Mar 22, 2023
3235801
Duplicate change files for beta release
dmceachernmsft Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change-beta/@azure-communication-react-ea81f159-4460-4f1a-96b4-5ce8dde4044b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Aria labels for people button to allow for voice access controls on windows.",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion change/@azure-communication-react-696ca73a-856e-4a9a-97e4-b6b66b3099b4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"type": "pre-release",
"type": "prerelease",
"comment": "Video Effects Button and Pane",
"packageName": "@azure/communication-react",
"email": "97124699+prabhjot-msft@users.noreply.github.com",
Expand Down
7 changes: 7 additions & 0 deletions change/@azure-communication-react-ea81f159-4460-4f1a-96b4-5ce8dde4044b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update Aria labels for people button to allow for voice access controls on windows.",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-composites/src/composites/CallComposite/components/CallControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ export const CallControls = (props: CallControlsProps & ContainerRectProps): JSX
/* @conditional-compile-remove(one-to-n-calling) */ /* @conditional-compile-remove(PSTN-calls) */
<People
checked={props.peopleButtonChecked}
ariaLabel={peopleButtonStrings?.label}
showLabel={options?.displayType !== 'compact'}
onClick={props.onPeopleButtonClicked}
data-ui-id="call-composite-people-button"
Expand Down
1 change: 1 addition & 0 deletions packages/react-composites/src/composites/CallWithChatComposite/CallWithChatControlBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ export const CallWithChatControlBar = (props: CallWithChatControlBarProps & Cont
{isEnabled(options?.peopleButton) && (
<PeopleButton
checked={props.peopleButtonChecked}
ariaLabel={peopleButtonStrings?.label}
showLabel={options.displayType !== 'compact'}
onClick={props.onPeopleButtonClicked}
data-ui-id="call-with-chat-composite-people-button"
Expand Down
⚡