-
Notifications
You must be signed in to change notification settings - Fork 78
Fix side pane when composite is narrow #2864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mgamis-msft
merged 27 commits into
main
from
mgamis/fix-side-pane-when-composite-is-narrow
Mar 31, 2023
Merged
Changes from 24 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a4ad6b0
set min width of composite content to 30rem
mgamis-msft 0085bac
Change files
mgamis-msft 9ffe3f7
Duplicate change files for beta release
mgamis-msft 6f5d789
fix incorrect file header
mgamis-msft caf7684
Add comment to variable and simplified variable name
mgamis-msft 6dea8c9
Merge branch 'main' into mgamis/fix-side-pane-when-composite-is-narrow
mgamis-msft 7fd5df8
include minWidth styling for stable
mgamis-msft 89db3f4
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] ebf30bf
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] ec03e75
Merge branch 'mgamis/fix-side-pane-when-composite-is-narrow' of https…
github-actions[bot] 4aedcf0
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] 8770a1d
Merge branch 'mgamis/fix-side-pane-when-composite-is-narrow' of https…
github-actions[bot] a8770f4
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] 379c26b
Merge branch 'mgamis/fix-side-pane-when-composite-is-narrow' of https…
github-actions[bot] b6d0c15
apply minwidth only when not mobile
mgamis-msft a75c0d8
Merge branch 'main' into mgamis/fix-side-pane-when-composite-is-narrow
mgamis-msft b019aca
cond-comp import
mgamis-msft f531529
cond-comp fix
mgamis-msft 7d66356
Merge branch 'main' into mgamis/fix-side-pane-when-composite-is-narrow
dmceachernmsft e52061f
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] 15a2770
Update packages/react-composites CallWithChatComposite browser test s…
github-actions[bot] 3f8e662
Merge branch 'mgamis/fix-side-pane-when-composite-is-narrow' of https…
github-actions[bot] c6f72de
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] 9fd3a74
Merge branch 'mgamis/fix-side-pane-when-composite-is-narrow' of https…
github-actions[bot] 8a0679c
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] c1c850c
Merge branch 'mgamis/fix-side-pane-when-composite-is-narrow' of https…
github-actions[bot] 9360e00
revert all snapshot updates
mgamis-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change-beta/@azure-communication-react-b577cf99-a1c9-4196-807a-9f3be0361d7b.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Fix side pane overlapping with composite when window is narrow", | ||
| "packageName": "@azure/communication-react", | ||
| "email": "79475487+mgamis-msft@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@azure-communication-react-b577cf99-a1c9-4196-807a-9f3be0361d7b.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "Fix side pane overlapping with composite when window is narrow", | ||
| "packageName": "@azure/communication-react", | ||
| "email": "79475487+mgamis-msft@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
packages/react-composites/src/composites/common/styles/Composite.styles.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT license. | ||
|
|
||
| /** | ||
| * This minimum width is to make sure the side pane does not overlap with the composite when the screen is narrow. | ||
| * | ||
| * @private | ||
| */ | ||
| export const compositeMinWidthRem = 30; | ||
Binary file modified
BIN
-5.89 KB
(85%)
...CallControls.test.ts-snapshots/custom-buttons-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-200 Bytes
(99%)
...rmetic/CallControls.test.ts-snapshots/no-mics-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-7 Bytes
(100%)
...etic/CallControls.test.ts-snapshots/no-videos-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.83 KB
(84%)
...snapshots/user-set-control-bar-button-options-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6 Bytes
(100%)
...mfDialpad.test.ts-snapshots/Call-Dtmf-Dialpad-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-174 Bytes
(100%)
...est.ts-snapshots/Dtmf-Dialpad-Hidden-Non-PSTN-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+67 Bytes
(100%)
...s-snapshots/all-errors-dismissed-on-error-bar-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-166 Bytes
(100%)
...snapshots/failure-to-start-video-on-error-bar-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-150 Bytes
(100%)
...est.ts-snapshots/multiple-errors-on-error-bar-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-156 Bytes
(100%)
...ts-snapshots/one-error-dismissed-on-error-bar-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+10 Bytes
(100%)
...HoldScreen.test.ts-snapshots/Call-hold-screen-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.58 KB
(96%)
...test.ts-snapshots/Call-screen-morebutton-open-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.18 KB
(88%)
...dScreen.test.ts-snapshots/Call-screen-resumed-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.38 KB
(91%)
...hots/horizontal-gallery-with-loading-spinners-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.84 KB
(91%)
...snapshots/video-gallery-with-loading-spinners-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-49 Bytes
(100%)
...creen.test.ts-snapshots/lobby-page-group-call-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-14 Bytes
(100%)
...en.test.ts-snapshots/lobby-page-one-to-n-call-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-16 Bytes
(100%)
...Screen.test.ts-snapshots/lobby-page-pstn-call-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+67 Bytes
(100%)
...ation.test.ts-snapshots/localized-call-screen-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.67 KB
(87%)
...rflow-gallery-in-rtl-with-1-audio-participant-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.68 KB
(87%)
...ots/overflow-gallery-with-1-audio-participant-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-6.15 KB
(89%)
...ow-gallery-with-1-joining-1-hold-participants-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.33 KB
(88%)
.../overflow-gallery-with-2-joining-participants-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5.58 KB
(86%)
...ots/overflow-gallery-with-joining-participant-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.19 KB
(94%)
...h-joining-participant-with-audio-participants-Mobile-Android-Portrait-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.91 KB
(93%)
...ining-participant-with-screen-share-and-video-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-3.44 KB
(94%)
...allery-with-many-audio-participants-on-page-1-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1.88 KB
(97%)
...ntal-gallery-with-joining-participant-dragged-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.21 KB
(96%)
...-gallery-with-many-audio-participants-dragged-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+215 Bytes
(100%)
...rmetic/PageState.test.ts-snapshots/lobby-page-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
....test.ts-snapshots/rooms-call-screen-attendee-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-527 Bytes
(99%)
...ooms-call-screen-consumer-remote-participants-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-431 Bytes
(99%)
...-snapshots/rooms-call-screen-devices-Attendee-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-431 Bytes
(99%)
...snapshots/rooms-call-screen-devices-presenter-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+67 Bytes
(100%)
...test.ts-snapshots/rooms-call-screen-presenter-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4.04 KB
(93%)
...reenshare.test.ts-snapshots/local-screenshare-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.01 KB
(95%)
.../remote-screenshare-horizontal-gallery-page-1-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2.03 KB
(96%)
...enshare-scrollable-horizontal-gallery-dragged-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+36 Bytes
(100%)
...ts-snapshots/banner-when-speaking-while-muted-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-153 Bytes
(100%)
....test.ts-snapshots/error-bar-camera-recovered-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-137 Bytes
(100%)
...snapshots/error-bar-camera-stops-unexpectedly-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-159 Bytes
(100%)
...t.ts-snapshots/error-bar-microphone-recovered-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-172 Bytes
(100%)
...shots/error-bar-microphone-stops-unexpectedly-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-228 Bytes
(100%)
...st.ts-snapshots/error-bar-when-camera-freezes-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-8.65 KB
(83%)
...pshots/tile-when-ufd-network-reconnect-is-bad-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.29 KB
(85%)
...o-avatar-with-person-icon-when-no-displayname-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.05 KB
(89%)
...ry-with-1-joining-1-hold-gridview-participant-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.05 KB
(89%)
...o-gallery-with-2-joining-gridview-participant-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5.92 KB
(90%)
...gallery-with-one-joining-gridview-participant-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-6.28 KB
(81%)
....ts-snapshots/video-gallery-camera-off-page-0-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4.41 KB
(89%)
....ts-snapshots/video-gallery-camera-off-page-1-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-3.86 KB
(88%)
...posite.test.ts-snapshots/video-gallery-page-0-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-3.95 KB
(87%)
...posite.test.ts-snapshots/video-gallery-page-1-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+59 Bytes
(100%)
...st.ts-snapshots/call-with-chat-gallery-screen-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+21 Bytes
(100%)
...snapshots/user-set-control-bar-button-options-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...h-chat-gallery-screen-with-10-unread-messages-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
...-chat-gallery-screen-with-one-unread-messages-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-44 Bytes
(100%)
...th-chat-more-drawer-submenu-microphone-screen-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-37 Bytes
(100%)
...th-chat-more-drawer-submenu-microphone-select-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
...-with-chat-more-drawer-submenu-speaker-screen-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
...-with-chat-more-drawer-submenu-speaker-select-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...shots/call-with-chat-more-drawer-dtmf-dialpad-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-2 Bytes
(100%)
...creen.test.ts-snapshots/lobby-page-group-call-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
...rmetic/PageState.test.ts-snapshots/lobby-page-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+59 Bytes
(100%)
...st.ts-snapshots/call-with-chat-gallery-screen-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+44 Bytes
(100%)
...snapshots/user-set-control-bar-button-options-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-1 Byte
(100%)
...h-chat-gallery-screen-with-10-unread-messages-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-17 Bytes
(100%)
...-chat-gallery-screen-with-one-unread-messages-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-44 Bytes
(100%)
...th-chat-more-drawer-submenu-microphone-screen-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-37 Bytes
(100%)
...th-chat-more-drawer-submenu-microphone-select-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
-5 Bytes
(100%)
...-with-chat-more-drawer-submenu-speaker-screen-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Binary file modified
BIN
+14 Bytes
(100%)
...-with-chat-more-drawer-submenu-speaker-select-Mobile-Android-Portrait-linux.png
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe add a small comment here as to what the number is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 👍