Skip to content

Auto-dismiss video effect errors #3160

Merged
prabhjot-msft merged 12 commits intomainfrom
prabhjot/autodismiss-errors
Jun 9, 2023
Merged

Auto-dismiss video effect errors #3160
prabhjot-msft merged 12 commits intomainfrom
prabhjot/autodismiss-errors

Conversation

@prabhjot-msft
Copy link
Copy Markdown
Contributor

@prabhjot-msft prabhjot-msft commented Jun 7, 2023

What

Auto-dismiss video effect errors

Why

https://skype.visualstudio.com/SPOOL/_workitems/edit/3266616

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@prabhjot-msft prabhjot-msft requested review from a team as code owners June 7, 2023 20:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 7, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-thhncuygoc.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 7, 2023 •
edited
Loading

Chat bundle size is not changed.

  • Current size: 10063236
  • Base size: 10063236
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 7, 2023 •
edited
Loading

Calling bundle size is increased❗.

  • Current size: 10008192
  • Base size: 10007978
  • Diff size: 214

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 7, 2023 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 10425998
  • Base size: 10425784
  • Diff size: 214

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-pgnkatxvyo.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@prabhjot-msft prabhjot-msft enabled auto-merge (squash) June 8, 2023 18:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

3 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-aewyfrtqey.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-xfnihwvgxj.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-jgrzvqaaok.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 8, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-usdqpmweoi.chromatic.com/

@prabhjot-msft prabhjot-msft merged commit 4a0b3f4 into main Jun 9, 2023
@prabhjot-msft prabhjot-msft deleted the prabhjot/autodismiss-errors branch June 9, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@mgamis-msft mgamis-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prabhjot-msft @JamesBurnside @mgamis-msft
⚡