[BugFix] Update Captions banner to not obstruct verticalGallery controls on landscape mobile#3305
Merged
dmceachernmsft merged 50 commits intomainfrom Jul 17, 2023
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
…hub.com/Azure/communication-ui-library into dmceachernmsft/verticalControlBarMobile
dmceachernmsft
added
the
update_snapshots
github-actions
Bot
removed
the
update_snapshots
Contributor
…hub.com/Azure/communication-ui-library into dmceachernmsft/verticalControlBarMobile
…hub.com/Azure/communication-ui-library into dmceachernmsft/verticalControlBarMobile
…hub.com/Azure/communication-ui-library into dmceachernmsft/verticalControlBarMobile
Contributor
edwardlee-msft
approved these changes
Jul 7, 2023
edwardlee-msft
approved these changes
Jul 7, 2023
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "type": "prerelease", | |||
| "comment": "Update Captions component for mobile landscape to not obstruct the verticalGallery", | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "comment": "Update Captions component for mobile landscape to not obstruct the verticalGallery", | |
| "comment": "Update Captions component for mobile landscape to not obstruct the VerticalGallery", |
Contributor
Contributor
| <Stack horizontalAlign="center"> | ||
| <Stack.Item style={{ width: props.isMobile ? mobileViewBannerWidth : desktopViewBannerWidth }}> | ||
| <_CaptionsBanner {...captionsBannerProps} {...handlers} strings={captionsBannerStrings} /> | ||
| <Stack.Item style={{ width: props.isMobile ? '90%' : '50%' }}> |
Contributor
There was a problem hiding this comment.
Should we use the mobileViewBannerWidth : desktopViewBannerWidth here?
carocao-msft
approved these changes
Jul 17, 2023
Contributor
Contributor
carocao-msft
pushed a commit
that referenced
this pull request
Jul 21, 2023
…ols on landscape mobile (#3305) * move control bar to left when landscape mode * refactor captions styles * move styling changes to component * remove CC demo code.. oops. * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Change control bar positioning logic * fix legacy control view * remove test.only * change to move control bar when container is 16:9 * address comments * fix stable build * Update change/@azure-communication-react-20b35cc7-52f0-40ed-8502-191c5fe29c38.json Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * update contol bar movement * control bar movement * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * fix nits --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com>
carocao-msft
added a commit
that referenced
this pull request
Jul 25, 2023
…rload with options bag (#3337) * fix mobile but * Change files * Duplicate change files for beta release * new join call api * Change files * Duplicate change files for beta release * videoOption type * [bugfix][a11y] Label side pane tab header currently active tab as aria-label (#3345) * Add selected state to side pane tabheader tabs * [Chat] introducing new type for future scalability (#3156) * [Chat] Fix chat sample app conditional comment (#3314) * Fix conditional comments for Chat sample app * Change files * Duplicate change files for beta release * Add type check to stable sample chat app * [Chat] cleaning up some unused property for FileMetaData (#3347) * [BugFix] Update Captions banner to not obstruct verticalGallery controls on landscape mobile (#3305) * move control bar to left when landscape mode * refactor captions styles * move styling changes to component * remove CC demo code.. oops. * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Change control bar positioning logic * fix legacy control view * remove test.only * change to move control bar when container is 16:9 * address comments * fix stable build * Update change/@azure-communication-react-20b35cc7-52f0-40ed-8502-191c5fe29c38.json Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * update contol bar movement * control bar movement * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * fix nits --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> * If video effect fails, none effect in picker is highlighted (#3334) * If video effect fails, none effect in picker is highlighted * Change files * Duplicate change files for beta release * Minor changes * Fix unread chat messages badge on the CallWithChatComposite being cleared when the call goes on hold (#3332) * Added capabilites feature to stateful client (#3340) * Added capabilites feature to stateful client * Change files * Duplicate change files for beta * update api undocumented comment --------- Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> * [Chat] Fix mention popover position incorrect when insert mention in the middle of long text (#3348) * Fix Mention Popover's position is too low when insert mention in the middle of a very long text * Change files * Duplicate change files for beta release * [A11y bugfix] Fix video effects pane tab ordering on call screen (#3351) * add focus zones * Change files * Duplicate change files for beta release * fix nit * Effects pane header misaligned (#3338) * Effects pane header misaligned * Change files * Duplicate change files for beta release * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Minor changes * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix breaking change check by ensuring dependencies are installed for the base branch (#3356) * Update pnpm version to 8.6.9 (#3357) * Fix bug where captions keep scrolling to the bottom when new captions are received (#3353) * scrolling bug * Change files * Duplicate change files for beta release * api * file * file * lint * update storybook * update storybook * update * update --------- Signed-off-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: edwardlee-msft <edwardlee@microsoft.com> Co-authored-by: JoshuaLai <9044372+JoshuaLai@users.noreply.github.com> Co-authored-by: Leah Xia <107075081+Leah-Xia-Microsoft@users.noreply.github.com> Co-authored-by: Donald McEachern <94866715+dmceachernmsft@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: prabhjot-msft <97124699+prabhjot-msft@users.noreply.github.com> Co-authored-by: James Burnside <2684369+JamesBurnside@users.noreply.github.com> Co-authored-by: mgamis-msft <79475487+mgamis-msft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
add compact mode to captions component to allow more vertical space on mobile.
moves control bar to left side when on landscape mobile
Why
Allows better experience for captions and overflow gallery on landscape mobile
https://skype.visualstudio.com/SPOOL/_workitems/edit/3217746
How Tested
locally see images ^ will update snapshots