Skip to content

[Chat] Fix mention popover content view is not wrapped up in the scroll view when the list is long #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leah-Xia-Microsoft merged 4 commits into from
Jul 13, 2023
Merged

[Chat] Fix mention popover content view is not wrapped up in the scroll view when the list is long #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dfb625
Fix mention popover content view floats out of the scroll view
Leah-Xia-Microsoft Jul 12, 2023
feca744
Change files
Leah-Xia-Microsoft Jul 12, 2023
6b1f966
Duplicate change files for beta release
Leah-Xia-Microsoft Jul 12, 2023
98cd786
Merge branch 'main' into leahxia/fix-mention-popover-content-float-ou…
Leah-Xia-Microsoft Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change-beta/@azure-communication-react-00d721c4-8922-4e27-a504-61ec5546c6e1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix mention popover content view is not wrapped up in the scroll view when the list is long",
"packageName": "@azure/communication-react",
"email": "107075081+Leah-Xia-Microsoft@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@azure-communication-react-00d721c4-8922-4e27-a504-61ec5546c6e1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix mention popover content view is not wrapped up in the scroll view when the list is long",
"packageName": "@azure/communication-react",
"email": "107075081+Leah-Xia-Microsoft@users.noreply.github.com",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion packages/react-components/src/components/styles/MentionPopover.style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ export const suggestionListContainerStyle = mergeStyles({
*/
export const suggestionListStyle = mergeStyles({
padding: '0.25rem 0rem 0',
overflow: 'visible'
overflow: 'visible',
overflowY: 'scroll'
});

/**
Expand Down
46 changes: 45 additions & 1 deletion packages/storybook/stories/SendBox/snippets/Mentions.snippet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,50 @@ const suggestions: Mention[] = [
id: '4',
displayText: 'Your user'
},
{
id: '5',
displayText: 'Milton Dyer'
},
{
id: '6',
displayText: 'Ella Stewart'
},
{
id: '7',
displayText: 'Todd Nelson'
},
{
id: '8',
displayText: 'Bertie Holman'
},
{
id: '9',
displayText: 'Chloe Alvarez'
},
{
id: '10',
displayText: 'Hannah Gibson'
},
{
id: '11',
displayText: "Amelia O'Connor"
},
{
id: '12',
displayText: "Amelia O'Connor"
},
{
id: '13',
displayText: 'Imogen Morris'
},
{
id: '14',
displayText: 'Freya Hayes'
},
{
id: '15',
displayText: 'Ellie Collins'
},
{
id: 'everyone',
displayText: 'Everyone'
Expand All @@ -37,7 +81,7 @@ export const MentionsExample: () => JSX.Element = () => {

return (
<FluentThemeProvider>
<div style={{ width: '31.25rem', marginTop: '12rem' }}>
<div style={{ width: '31.25rem', marginTop: '15rem' }}>
<SendBox
onSendMessage={async (message) => {
timeoutRef.current = setTimeout(() => {
Expand Down
⚡