Skip to content

Remove Fluent NorthStar#3578

Merged
emlynmac merged 181 commits intomainfrom
feature/remove-northstar
Oct 3, 2023
Merged

Remove Fluent NorthStar#3578
emlynmac merged 181 commits intomainfrom
feature/remove-northstar

Conversation

@emlynmac
Copy link
Copy Markdown
Member

@emlynmac emlynmac commented Sep 11, 2023 •
edited
Loading

What

Remove NorthStar fluent dependency and replace with fluent 9 controls.
Also update the styling on system messages to a smaller font and reduced vertical padding.
Added localized timestamp by default to chat messages

Why

Fluent n* is deprecated; not compatible with react 18

How Tested

Storybook, CI, manual testing.

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.
    Potentially has some impact to custom styling implementations requiring the components previously tied to n* fluent

@emlynmac emlynmac self-assigned this Sep 11, 2023
@emlynmac emlynmac requested review from a team as code owners September 11, 2023 23:40
@emlynmac emlynmac requested review from a team as code owners September 11, 2023 23:40
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-tmudsvgxky.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2023

Failed to pass the component examples UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2023 •
edited
Loading

CallWithChat bundle size is decreased✅.

  • Current size: 6262012
  • Base size: 6570863
  • Diff size: -308851

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2023 •
edited
Loading

Chat bundle size is decreased✅.

  • Current size: 1520384
  • Base size: 1829213
  • Diff size: -308829

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2023 •
edited
Loading

Calling bundle size is decreased✅.

  • Current size: 5453256
  • Base size: 5917074
  • Diff size: -463818

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 11, 2023

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Update embed html bundle snapshots
e45a2c4
@github-actions
Merge branch 'feature/remove-northstar' of https://github.com/Azure/c…
4c1c3a9 
…ommunication-ui-library into feature/remove-northstar
@github-actions
Update component examples snapshots
b72303b
@github-actions
Merge branch 'feature/remove-northstar' of https://github.com/Azure/c…
b230fbe 
…ommunication-ui-library into feature/remove-northstar
@github-actions
Update packages/react-composites CallComposite browser test snapshots
8ec32f2
@github-actions
Merge branch 'feature/remove-northstar' of https://github.com/Azure/c…
4abf1ef 
…ommunication-ui-library into feature/remove-northstar
@github-actions
Update packages/react-composites CallComposite browser test snapshots
c9a28a2
@github-actions
Merge branch 'feature/remove-northstar' of https://github.com/Azure/c…
da81278 
…ommunication-ui-library into feature/remove-northstar
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-fjyptgbqlt.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-nmotpuulam.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-nfyxaqpivh.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-bivuzdziri.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-jjhdkkluwz.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-pkrbwfpdqe.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-qwvienpdnu.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ytoedpswbj.chromatic.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@emlynmac emlynmac

@palatter palatter

@dmceachernmsft dmceachernmsft

@vhuseinova-msft vhuseinova-msft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@emlynmac @JamesBurnside @palatter @dmceachernmsft @vhuseinova-msft @Leah-Xia-Microsoft
⚡