Skip to content

Custom Button Injection; stabilize, storybook, refactor#3642

Merged
edwardlee-msft merged 43 commits intomainfrom
elee/custom-button-injection-storybook
Oct 19, 2023
Merged

Custom Button Injection; stabilize, storybook, refactor#3642
edwardlee-msft merged 43 commits intomainfrom
elee/custom-button-injection-storybook

Conversation

@edwardlee-msft
Copy link
Copy Markdown
Contributor

@edwardlee-msft edwardlee-msft commented Oct 3, 2023 •
edited
Loading

What

CustomButtonInjection storybook entry and snippets.
Also includes @internal export of MockCallAdapter
image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-maqxxohghq.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023 •
edited
Loading

Chat bundle size is increased❗.

  • Current size: 1518671
  • Base size: 1518519
  • Diff size: 152

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023 •
edited
Loading

Calling bundle size is increased❗.

  • Current size: 5593820
  • Base size: 5593557
  • Diff size: 263

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023 •
edited
Loading

CallWithChat bundle size is increased❗.

  • Current size: 6400612
  • Base size: 6400349
  • Diff size: 263

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 3, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-uwrygeioay.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 6, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-renaewunnt.chromatic.com/

@edwardlee-msft edwardlee-msft changed the title CustomButtonInjection storybook entry and snippets [DRAFT] CustomButtonInjection storybook entry and snippets Oct 6, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 10, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-grzivzrxkc.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 11, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-nvgbpedxzm.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 11, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ysyljbcacl.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2023

Failed to pass the Static HTML UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 16, 2023

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ovcqvluavc.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 18, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Oct 18, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Oct 18, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 18, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-ashxmftlzj.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 18, 2023

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-vdxjfpprjl.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-avgkotuihp.chromatic.com/

@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Oct 19, 2023
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Oct 19, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-amkrxilebi.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-qoaurcynhj.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-bbfxlczkzp.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

Storybook URL https://60c7ae6891f0e90039d7cd54-rgyyjkfovf.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 43201 / 67084
64.39%		 43201 / 67084
64.39%		 888 / 1902
46.68%		 2632 / 4139
63.59%
Current 43253 / 66984
64.57%		 43253 / 66984
64.57%		 888 / 1900
46.73%		 2632 / 4143
63.52%
Diff 52 / -100
0.18%		 52 / -100
0.18%		 0 / -2
0.05%		 0 / 4
-0.07%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 19, 2023

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 20971 / 32668
64.19%		 20971 / 32668
64.19%		 576 / 994
57.94%		 1701 / 2661
63.92%
Current 20971 / 32668
64.19%		 20971 / 32668
64.19%		 576 / 994
57.94%		 1701 / 2661
63.92%
Diff 0 / 0
0%		 0 / 0
0%		 0 / 0
0%		 0 / 0
0%

@edwardlee-msft edwardlee-msft merged commit 6523b81 into main Oct 19, 2023
@edwardlee-msft edwardlee-msft deleted the elee/custom-button-injection-storybook branch October 19, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft dmceachernmsft approved these changes

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@PorterNan PorterNan Awaiting requested review from PorterNan PorterNan is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@AmyL219 AmyL219 Awaiting requested review from AmyL219 AmyL219 is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@JamesBurnside JamesBurnside

@dmceachernmsft dmceachernmsft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edwardlee-msft @JamesBurnside @dmceachernmsft
⚡