Skip to content

[Chat] Menu button accessibility fix #3672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhuseinova-msft merged 4 commits into from
Oct 11, 2023
Merged

[Chat] Menu button accessibility fix #3672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ab562b
Fixed menu button accessibility issue
vhuseinova-msft Oct 11, 2023
2d7f1dc
Merge remote-tracking branch 'origin/main' into vhuseinova/messsage-m…
vhuseinova-msft Oct 11, 2023
1e8cb7b
Change files
vhuseinova-msft Oct 11, 2023
b9fe882
Duplicate change files for beta release
vhuseinova-msft Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-592e9920-18ad-4711-a953-a7f4d5737e79.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "FluentUI",
"comment": "Fix an issue when the menu button was not accessible sometimes",
"packageName": "@azure/communication-react",
"email": "98852890+vhuseinova-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-592e9920-18ad-4711-a953-a7f4d5737e79.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "FluentUI",
"comment": "Fix an issue when the menu button was not accessible sometimes",
"packageName": "@azure/communication-react",
"email": "98852890+vhuseinova-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
20 changes: 9 additions & 11 deletions packages/react-components/src/components/ChatMessage/ChatMessageComponentAsMessageBubble.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,7 @@ const MessageBubble = (props: ChatMessageComponentAsMessageBubbleProps): JSX.Ele
attached !== 'top' ? chatMyMessageStyles.bodyAttached : undefined,
mergeStyles(messageContainerStyle)
),
style: { ...createStyleFromV8Style(messageContainerStyle) },
// make body not focusable to remove repetitions from narrators.
// inner components are already focusable
tabIndex: -1,
role: 'presentation'
style: { ...createStyleFromV8Style(messageContainerStyle) }
}}
root={{
className: chatMyMessageStyles.root,
Expand All @@ -343,7 +339,6 @@ const MessageBubble = (props: ChatMessageComponentAsMessageBubbleProps): JSX.Ele
// `focused` controls is focused the whole `ChatMessage` or any of its children. When we're navigating
// with keyboard the focused element will be changed and there is no way to use `:focus` selector
const shouldPreserveFocusState = e.currentTarget.contains(e.relatedTarget);

setFocused(shouldPreserveFocusState);
},
onFocus: () => {
Expand All @@ -370,6 +365,7 @@ const MessageBubble = (props: ChatMessageComponentAsMessageBubbleProps): JSX.Ele
}
details={getMessageDetails()}
actions={{
tabIndex: 0,
children: actionMenuProps?.children,
className: mergeClasses(
chatMyMessageStyles.menu,
Expand Down Expand Up @@ -404,16 +400,18 @@ const MessageBubble = (props: ChatMessageComponentAsMessageBubbleProps): JSX.Ele
<FluentChatMessage
attached={attached}
key={props.message.messageId}
root={{ className: chatMessageStyles.root }}
author={<Text className={chatMessageAuthorStyle}>{message.senderDisplayName}</Text>}
body={{
className: chatItemMessageContainerClassName,
style: { ...createStyleFromV8Style(messageContainerStyle) },
root={{
className: chatMessageStyles.root,
// make body not focusable to remove repetitions from narrators.
// inner components are already focusable
tabIndex: -1,
role: 'none'
}}
author={<Text className={chatMessageAuthorStyle}>{message.senderDisplayName}</Text>}
Comment thread
vhuseinova-msft marked this conversation as resolved.
body={{
className: chatItemMessageContainerClassName,
style: { ...createStyleFromV8Style(messageContainerStyle) }
}}
data-ui-id="chat-composite-message"
timestamp={
<Text className={chatMessageDateStyle} data-ui-id={ids.messageTimestamp}>
Expand Down
⚡