Skip to content

[Bugfix] Update padding on video effects picker #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmceachernmsft merged 8 commits into from
Oct 31, 2023
Merged

[Bugfix] Update padding on video effects picker #3725

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
10bfb94
fix padding
dmceachernmsft Oct 30, 2023
2844ff5
Change files
dmceachernmsft Oct 30, 2023
2488782
Duplicate change files for beta release
dmceachernmsft Oct 30, 2023
2e47cb9
Merge branch 'main' into dmceachernmsft/picker-margin-fix
dmceachernmsft Oct 30, 2023
513e148
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] Oct 31, 2023
9e85f54
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] Oct 31, 2023
8073ca5
Merge branch 'dmceachernmsft/picker-margin-fix' of https://github.com…
github-actions[bot] Oct 31, 2023
2558651
Merge branch 'main' into dmceachernmsft/picker-margin-fix
dmceachernmsft Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-593955ef-a0b0-410e-a739-ae86d07779fc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Fix the padding for the warning bar in the effects picker and the background label",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-593955ef-a0b0-410e-a739-ae86d07779fc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Fix the padding for the warning bar in the effects picker and the background label",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-composites/src/composites/common/VideoEffectsPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ const VideoEffectsPaneTrampoline = (

/* @conditional-compile-remove(video-background-effects) */
return (
<Stack className={mergeStyles({ paddingLeft: '0.5rem' })}>
<Stack tokens={{ childrenGap: '0.75rem' }} className={mergeStyles({ paddingLeft: '0.5rem' })}>
{activeVideoEffectError && isCameraOn && (
<MessageBar messageBarType={MessageBarType.error} onDismiss={() => onDismissError(activeVideoEffectError)}>
{locale.strings.call.unableToStartVideoEffect}
Expand Down
⚡