Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Dispose of the unparented views when we hit a state that has us actually in a call",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Dispose of the unparented views when we hit a state that has us actually in a call",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,16 @@ export class AzureCommunicationCallAdapter<AgentType extends CallAgent | BetaTea
this.context.setCurrentCallId(this.call.id);
}

// if we have a call state we need to dispose of the unparented views
Comment thread
dmceachernmsft marked this conversation as resolved.
Outdated
if (
(this.call?.state === 'InLobby' || this.call?.state === 'Connected') &&
this.callClient.getState().deviceManager.unparentedViews.length > 0
) {
this.callClient.getState().deviceManager.unparentedViews.forEach((view) => {
this.callClient.disposeView(undefined, undefined, view);
});
}

this.context.updateClientState(clientState);

/* @conditional-compile-remove(call-transfer) */
Expand Down