-
Notifications
You must be signed in to change notification settings - Fork 78
[Calling sounds] Fix issue where ringing sound keeps playing on the disconnecting screen #3889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0afa968
stop ringing when disconnecting
dmceachernmsft 6beccc4
Change files
dmceachernmsft e03f9b8
Duplicate change files for beta release
dmceachernmsft ba1e535
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft 3bf2308
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft 7a5ac64
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft 419a5e8
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft 452908e
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft 10e7d96
update helper to be for whether to play ringing or not
dmceachernmsft cd6e63f
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft a360551
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft 65e20a1
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft bb143fb
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft b65ddf5
Merge branch 'main' into dmceachernmsft/ringing-fix
dmceachernmsft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
9 changes: 9 additions & 0 deletions
9
change-beta/@azure-communication-react-2472da6c-81f7-4edd-b8a6-37a9fba9a904.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "area": "fix", | ||
| "workstream": "Calling Sounds", | ||
| "comment": "Stop the ringing sound from playing when the call disconnects before the callee answers", | ||
| "packageName": "@azure/communication-react", | ||
| "email": "94866715+dmceachernmsft@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
9 changes: 9 additions & 0 deletions
9
change/@azure-communication-react-2472da6c-81f7-4edd-b8a6-37a9fba9a904.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "area": "fix", | ||
| "workstream": "Calling Sounds", | ||
| "comment": "Stop the ringing sound from playing when the call disconnects before the callee answers", | ||
| "packageName": "@azure/communication-react", | ||
| "email": "94866715+dmceachernmsft@users.noreply.github.com", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.