Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Allow mic to be active in the lobby screen",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Bug fix",
"comment": "Allow mic to be active in the lobby screen",
"packageName": "@azure/communication-react",
"email": "94866715+dmceachernmsft@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@ export const Microphone = (props: {
const unmuteMicCapability = adapter.getState().call?.capabilitiesFeature?.capabilities.unmuteMic;

/**
* When call is in Lobby, microphone button should be disabled.
* When call is in connecting state, microphone button should be disabled.
* This is due to to headless limitation where a call can not be muted/unmuted in lobby.
*/
if (_isInLobbyOrConnecting(callStatus)) {
microphoneButtonProps.disabled = true;
if (callStatus === 'Connecting') {
// Lobby page should show the microphone status that was set on the local preview/configuration
// page until the user successfully joins the call.
microphoneButtonProps.checked = isLocalMicrophoneEnabled;
Copy link
Copy Markdown
Contributor

@mgamis-msft mgamis-msft Dec 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR but getLocalMicrophoneEnabled selector should be changed to getLocalMicrophoneOn or something. The verb 'enabled' makes it sound like it should decide if the button is enabled/disabled.

Expand All @@ -56,7 +55,6 @@ export const Microphone = (props: {
}
: {};
const styles = useMemo(() => concatButtonBaseStyles(props.styles ?? {}), [props.styles]);

// tab focus on MicrophoneButton on page load
return (
<MicrophoneButton
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.