-
Notifications
You must be signed in to change notification settings - Fork 78
[Stable blocking] Prevent showing screenShareButton when formFactor is set to mobile #3915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
73b8b71
86b2021
6f0f124
561c371
d721e94
076eb34
0428913
643ed9b
f07918d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "type": "none", | ||
| "area": "fix", | ||
| "workstream": "Screenshare button", | ||
| "comment": "Prevent showing screenShareButton when formFactor is set to mobile", | ||
| "packageName": "@azure/communication-react", | ||
| "email": "79475487+mgamis-msft@users.noreply.github.com", | ||
| "dependentChangeType": "none" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "type": "none", | ||
| "area": "fix", | ||
| "workstream": "Screenshare button", | ||
| "comment": "Prevent showing screenShareButton when formFactor is set to mobile", | ||
| "packageName": "@azure/communication-react", | ||
| "email": "79475487+mgamis-msft@users.noreply.github.com", | ||
| "dependentChangeType": "none" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -150,9 +150,11 @@ export const CallScreen = (props: CallScreenProps): JSX.Element => { | |
|
|
||
| const options: CallWithChatCompositeOptions = useMemo( | ||
| () => ({ | ||
| callControls: { | ||
| screenShareButton: !shouldDisableScreenShare | ||
| } | ||
| callControls: shouldDisableScreenShare | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid setting the whole callControls object based on shouldDisableScreenShare, makes it hard for someone to add options to this in future (they'd have to move the shouldDisableScreenShare) ?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (Or fix the shouldDisableScreenshare to be isMobile || isIOS instead of just isIOS) |
||
| ? { | ||
| screenShareButton: false | ||
| } | ||
| : undefined | ||
| }), | ||
| [shouldDisableScreenShare] | ||
| ); | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.