[BugFix] background blur keypress fix#3927
Merged
dmceachernmsft merged 4 commits intomainfrom Dec 19, 2023
Merged
Conversation
dmceachernmsft
requested review from
AmyL219,
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
PorterNan,
alkwa-msft,
carocao-msft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft,
vhuseinova-msft and
waynemo
Contributor
Contributor
Calling bundle size is decreased✅.
|
Contributor
Chat bundle size is decreased✅.
|
Contributor
CallWithChat bundle size is decreased✅.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
edwardlee-msft
approved these changes
Dec 18, 2023
carocao-msft
approved these changes
Dec 19, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove custom onKeypress handler from button in picker items
Why
Moves the responsibility of performing the action to the button. we are causing a second application of the background with the onKeypress handler. This is also a bug on fluent. Image of the errors and some debugging lines:
https://skype.visualstudio.com/SPOOL/_workitems/edit/3485708
How Tested
Validated this fixed the keypress application of the background.