Skip to content

[Chat] Fix for a race condition for "The message is deleted" announcement #3946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhuseinova-msft merged 5 commits into from
Dec 22, 2023
Merged

[Chat] Fix for a race condition for "The message is deleted" announcement #3946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a806a9
Fix for a race condition for "The message is deleted" announcement
vhuseinova-msft Dec 22, 2023
bd57588
Change files
vhuseinova-msft Dec 22, 2023
c1433a4
Duplicate change files for beta release
vhuseinova-msft Dec 22, 2023
5dc1018
Merge remote-tracking branch 'origin/main' into vhuseinova/delete-mes…
vhuseinova-msft Dec 22, 2023
cd3da9d
Code review fixes
vhuseinova-msft Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-09bb9bd5-6808-44dd-94d1-4a6bc9cc2581.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Accessibility",
"comment": "Fix for a race condition for \"The message is deleted\" announcement",
"packageName": "@azure/communication-react",
"email": "98852890+vhuseinova-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-09bb9bd5-6808-44dd-94d1-4a6bc9cc2581.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Accessibility",
"comment": "Fix for a race condition for \"The message is deleted\" announcement",
"packageName": "@azure/communication-react",
"email": "98852890+vhuseinova-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/react-components/src/components/MessageThread.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,10 +728,12 @@ export const MessageThreadWrapper = (props: MessageThreadProps): JSX.Element =>
return;
}
try {
await onDeleteMessage(messageId);
// reset deleted message label in case if there was a value already (messages are deleted 1 after another)
setDeletedMessageAriaLabel(undefined);
setLatestDeletedMessageId(messageId);
// we should set up latestDeletedMessageId before the onDeleteMessage call
// as otherwise in very rare cases the messages array can be updated before latestDeletedMessageId
await onDeleteMessage(messageId);
Comment thread
vhuseinova-msft marked this conversation as resolved.
} catch (e) {
console.log('onDeleteMessage failed: messageId', messageId, 'error', e);
}
Expand Down
⚡