Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "improvement",
"workstream": "MessageThread Component",
"comment": "Allow onRenderAvatar to return undefined to hide avatar",
"packageName": "@azure/communication-react",
"email": "3941071+emlynmac@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "minor",
"area": "improvement",
"workstream": "MessageThread Component",
"comment": "Allow onRenderAvatar to return undefined to hide avatar",
"packageName": "@azure/communication-react",
"email": "3941071+emlynmac@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,40 @@ export const FluentChatMessageComponent = (props: FluentChatMessageComponentWrap
return { className: mergeClasses(chatMessageRenderStyles.rootMessage, chatMessageRenderStyles.rootCommon) };
}, [chatMessageRenderStyles.rootCommon, chatMessageRenderStyles.rootMessage]);

const avatar = useMemo(() => {
const chatAvatarStyle = shouldShowAvatar ? gutterWithAvatar : gutterWithHiddenAvatar;
const personaOptions: IPersona = {
hidePersonaDetails: true,
size: PersonaSize.size32,
text: message.senderDisplayName,
showOverflowTooltip: false
};
let renderedAvatar;
if (onRenderAvatar) {
const avatarComponent = onRenderAvatar?.(message.senderId, personaOptions);
if (!avatarComponent) {
return undefined;
} else {
renderedAvatar = avatarComponent;
}
}
return (
<div className={mergeStyles(chatAvatarStyle)}>
{renderedAvatar ? renderedAvatar : <Persona {...personaOptions} />}
</div>
);
}, [message.senderDisplayName, message.senderId, onRenderAvatar, shouldShowAvatar]);

const messageBodyProps = useMemo(() => {
return {
// chatItemMessageContainer used in className and style prop as style prop can't handle CSS selectors
className: mergeClasses(
chatMessageRenderStyles.bodyCommon,
!shouldShowAvatar ? chatMessageRenderStyles.bodyWithoutAvatar : chatMessageRenderStyles.bodyWithAvatar,
!shouldShowAvatar
? avatar
? chatMessageRenderStyles.bodyWithoutAvatar
: chatMessageRenderStyles.bodyHiddenAvatar
: chatMessageRenderStyles.bodyWithAvatar,
shouldOverlapAvatarAndMessage ? chatMessageRenderStyles.avatarOverlap : chatMessageRenderStyles.avatarNoOverlap,
mergeStyles(styles?.chatItemMessageContainer)
),
Expand All @@ -145,31 +173,18 @@ export const FluentChatMessageComponent = (props: FluentChatMessageComponentWrap
role: 'none'
};
}, [
chatMessageRenderStyles.avatarNoOverlap,
chatMessageRenderStyles.avatarOverlap,
chatMessageRenderStyles.bodyCommon,
chatMessageRenderStyles.bodyWithAvatar,
chatMessageRenderStyles.bodyWithoutAvatar,
shouldOverlapAvatarAndMessage,
chatMessageRenderStyles.bodyHiddenAvatar,
chatMessageRenderStyles.bodyWithAvatar,
chatMessageRenderStyles.avatarOverlap,
chatMessageRenderStyles.avatarNoOverlap,
shouldShowAvatar,
avatar,
shouldOverlapAvatarAndMessage,
styles?.chatItemMessageContainer
]);

const avatar = useMemo(() => {
const chatAvatarStyle = shouldShowAvatar ? gutterWithAvatar : gutterWithHiddenAvatar;
const personaOptions: IPersona = {
hidePersonaDetails: true,
size: PersonaSize.size32,
text: message.senderDisplayName,
showOverflowTooltip: false
};
return (
<div className={mergeStyles(chatAvatarStyle)}>
{onRenderAvatar ? onRenderAvatar?.(message.senderId, personaOptions) : <Persona {...personaOptions} />}
</div>
);
}, [message.senderDisplayName, message.senderId, onRenderAvatar, shouldShowAvatar]);

// Fluent UI message components are used here as for default message renderer,
// timestamp and author name should be shown but they aren't shown for custom renderer.
// More investigations are needed to check if this can be simplified with states.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ export const useChatMessageRenderStyles = makeStyles({
marginLeft: `${AVATAR_MARGIN_LEFT}rem`,
marginTop: '0'
},
bodyHiddenAvatar: {
marginLeft: 0,
marginTop: 0
},
bodyWithAvatar: {
marginLeft: `0`,
marginTop: '0.75rem'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export type AvatarPersonaData = {
*
* @public
*/
export type AvatarPersonaDataCallback = (userId: string) => Promise<AvatarPersonaData>;
export type AvatarPersonaDataCallback = (userId: string) => Promise<AvatarPersonaData | undefined>;

/**
* @private
Expand Down