Skip to content

[Chat] Fixed the issue where RTE doesn't send HTML messages if there are attached files #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpeng-ms merged 3 commits into from
Jun 18, 2024
Merged

[Chat] Fixed the issue where RTE doesn't send HTML messages if there are attached files #4747

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd9c325
Update createHandlers.ts
jpeng-ms Jun 18, 2024
5bfd326
Change files
jpeng-ms Jun 18, 2024
48ac5d2
updated changelog wording
jpeng-ms Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-cc2ef409-ce98-484f-8b0e-d047cc26af08.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "File Sharing",
"comment": "Fixed the issue where RTE cannot send rich text with file attachments",
Copy link
Copy Markdown
Member

@vhuseinova-msft vhuseinova-msft Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please use rich text editor instead of RTE?

Copy link
Copy Markdown
Member Author

@jpeng-ms jpeng-ms Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks updated

"packageName": "@azure/communication-react",
"email": "109105353+jpeng-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-cc2ef409-ce98-484f-8b0e-d047cc26af08.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "File Sharing",
"comment": "Fixed the issue where RTE cannot send rich text with file attachments",
"packageName": "@azure/communication-react",
"email": "109105353+jpeng-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
3 changes: 2 additions & 1 deletion packages/chat-component-bindings/src/handlers/createHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ export const createDefaultChatHandlers = memoizeOne(
metadata: {
...options?.metadata,
fileSharingMetadata: JSON.stringify(options?.attachments)
}
},
type: options.type
};
await chatThreadClient.sendMessage(sendMessageRequest, chatSDKOptions);
return;
Expand Down
⚡