Skip to content

Fix error when listening to spotlight and capabilities events for call with chat adapter #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgamis-msft merged 5 commits into from
Aug 24, 2024
Merged

Fix error when listening to spotlight and capabilities events for call with chat adapter #5066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f81f62
Fix event subscriptions to capabilitiesChanged and spotlightChanged e…
mgamis-msft Aug 23, 2024
f2effb1
Change files
mgamis-msft Aug 23, 2024
a2c0fcf
Update changelog comment
mgamis-msft Aug 23, 2024
788269f
fix wrong unsubscription
mgamis-msft Aug 23, 2024
c560f7e
Merge branch 'main' into mgamis/fix-spotlight-and-capabilities-events…
mgamis-msft Aug 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-338b3032-95c2-4539-9187-37939d37c21e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "CallWithChatAdapter events",
"comment": "Fix error when listening to capabilitiesChanged and spotlightChanged events from AzureCommunicationCallWithChatAdapter",
"packageName": "@azure/communication-react",
"email": "79475487+mgamis-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-338b3032-95c2-4539-9187-37939d37c21e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "CallWithChatAdapter events",
"comment": "Fix error when listening to capabilitiesChanged and spotlightChanged events from AzureCommunicationCallWithChatAdapter",
"packageName": "@azure/communication-react",
"email": "79475487+mgamis-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
12 changes: 12 additions & 0 deletions ...tes/src/composites/CallWithChatComposite/adapter/AzureCommunicationCallWithChatAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,12 @@ export class AzureCommunicationCallWithChatAdapter implements CallWithChatAdapte
case 'chatInitialized':
this.emitter.on(event, listener);
break;
case 'capabilitiesChanged':
this.callAdapter.on('capabilitiesChanged', listener);
break;
case 'spotlightChanged':
this.callAdapter.on('spotlightChanged', listener);
break;
default:
throw `Unknown AzureCommunicationCallWithChatAdapter Event: ${event}`;
}
Expand Down Expand Up @@ -943,6 +949,12 @@ export class AzureCommunicationCallWithChatAdapter implements CallWithChatAdapte
case 'chatInitialized':
this.emitter.off(event, listener);
break;
case 'capabilitiesChanged':
this.callAdapter.off('capabilitiesChanged', listener);
break;
case 'spotlightChanged':
this.callAdapter.off('spotlightChanged', listener);
break;
default:
throw `Unknown AzureCommunicationCallWithChatAdapter Event: ${event}`;
}
Expand Down
⚡