Skip to content

Fix wifi warning icon size in error bar #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mgamis-msft merged 7 commits into from
Dec 12, 2024
Merged

Fix wifi warning icon size in error bar #5282

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b1fbd70
Fix error bar icon size for low network quality and local video freeze
mgamis-msft Oct 9, 2024
8b439ba
Change files
mgamis-msft Oct 9, 2024
4d45b75
Merge branch 'main' into mgamis/fix-wifi-warning-icon-size
alkwa-msft Dec 2, 2024
9bfbc5e
Merge branch 'main' into mgamis/fix-wifi-warning-icon-size
dmceachernmsft Dec 12, 2024
b391531
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] Dec 12, 2024
d04472c
Update packages/react-composites CallComposite browser test snapshots
github-actions[bot] Dec 12, 2024
58d0721
Merge branch 'mgamis/fix-wifi-warning-icon-size' of https://github.co…
github-actions[bot] Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/@azure-communication-react-3aa94f88-9194-4129-901f-88ed39a8751b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Error bar",
"comment": "Fix error bar icon size for low network quality and local video freeze",
"packageName": "@azure/communication-react",
"email": "79475487+mgamis-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 2 additions & 5 deletions packages/react-components/src/theming/icons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,8 @@ export type ComponentIcons = Record<keyof typeof DEFAULT_COMPONENT_ICONS, JSX.El

const WifiWarning16Filled = (): JSX.Element => (
// All ErrorBar icons are 16px x 16px (when 1rem = 16 px).
// There is no 16px version of this icon in the fluent icon package, so scale the larger
// one down to required size.
<div className={mergeStyles({ transform: 'scale(0.8)' })}>
<WifiWarning20Filled />
</div>
// There is no 16px version of this icon in the fluent icon package, so set height and width to 1rem.
<WifiWarning20Filled style={{ height: '1rem', width: '1rem' }} />
);

const MoreHorizontal18Regular = (): JSX.Element => (
Expand Down
⚡