Skip to content

Fixed an issue with types for usePropsFor#5723

Merged
vhuseinova-msft merged 2 commits intomainfrom
vhuseinova/breaking-change-check-fix
Mar 20, 2025
Merged

Fixed an issue with types for usePropsFor#5723
vhuseinova-msft merged 2 commits intomainfrom
vhuseinova/breaking-change-check-fix

Conversation

@vhuseinova-msft
Copy link
Copy Markdown
Member

@vhuseinova-msft vhuseinova-msft commented Mar 20, 2025 •
edited
Loading

What

With the previous implementation Typescript couldn't correctly infer the return type of the useCallingPropsFor and useChatPropsFor hooks. Change the return type to fix the issue

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@vhuseinova-msft vhuseinova-msft requested review from a team as code owners March 20, 2025 18:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

Chat bundle size is not changed.

  • Current size: 1775227
  • Base size: 1775227
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-oywtulrvlo.chromatic.com/

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58477 / 94462
61.9%		 58477 / 94462
61.9%		 1180 / 2698
43.73%		 3570 / 5851
61.01%
Current 58486 / 94462
61.91%		 58486 / 94462
61.91%		 1180 / 2698
43.73%		 3551 / 5848
60.72%
Diff 9 / 0
0.01%		 9 / 0
0.01%		 0 / 0
0%		 -19 / -3
-0.29%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29303 / 45995
63.7%		 29303 / 45995
63.7%		 808 / 1476
54.74%		 2401 / 3819
62.86%
Current 29299 / 45995
63.7%		 29299 / 45995
63.7%		 808 / 1476
54.74%		 2412 / 3824
63.07%
Diff -4 / 0
0%		 -4 / 0
0%		 0 / 0
0%		 11 / 5
0.21%

@vhuseinova-msft vhuseinova-msft merged commit 03759ec into main Mar 20, 2025
57 checks passed
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/breaking-change-check-fix branch March 20, 2025 20:25
@vhuseinova-msft vhuseinova-msft restored the vhuseinova/breaking-change-check-fix branch March 20, 2025 23:10
vhuseinova-msft added a commit that referenced this pull request Mar 20, 2025
@vhuseinova-msft
Revert "Fix returned types for useChatPropsFor and useCallingPropsFo (#…
3c10f7a 
…5723)"

This reverts commit 03759ec.
@vhuseinova-msft vhuseinova-msft mentioned this pull request Mar 20, 2025
Merged
vhuseinova-msft added a commit that referenced this pull request Mar 20, 2025
@vhuseinova-msft
Revert "Fix returned types for useChatPropsFor and useCallingPropsFo (#…
05d29fc 
…5723)" (#5726)

This reverts commit 03759ec.
@vhuseinova-msft vhuseinova-msft deleted the vhuseinova/breaking-change-check-fix branch May 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesBurnside JamesBurnside JamesBurnside approved these changes

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

+1 more reviewer

@alkwa-msft alkwa-msft alkwa-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JamesBurnside JamesBurnside

@emlynmac emlynmac

@dmceachernmsft dmceachernmsft

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vhuseinova-msft @JamesBurnside @alkwa-msft @emlynmac @dmceachernmsft
⚡