Fix issues where together mode stream keeps loading unitl views are c…#5724
Merged
Fix issues where together mode stream keeps loading unitl views are c…#5724
Conversation
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nfuzndtzle.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ryytaqpwqg.chromatic.com/ |
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wmaulmjsmx.chromatic.com/ |
cn0151
added
the
does not need changelog
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-swqmjajuin.chromatic.com/ |
Contributor
Chat bundle size is not changed.
|
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
cn0151
requested review from
JamesBurnside,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
jimchou-dev,
jpeng-ms,
mgamis-msft,
prabhjot-msft and
vhuseinova-msft
edwardlee-msft
approved these changes
Mar 26, 2025
dmceachernmsft
approved these changes
Mar 26, 2025
mgamis-msft
pushed a commit
that referenced
this pull request
Mar 27, 2025
#5724) * Fix issues where together mode stream keeps loading unitl views are changed * Ensure the togethe mode view shows only in Teams call /Teams meeting
3 tasks
mgamis-msft
added a commit
that referenced
this pull request
Mar 27, 2025
* Fix issues where together mode stream keeps loading unitl views are c… (#5724) * Fix issues where together mode stream keeps loading unitl views are changed * Ensure the togethe mode view shows only in Teams call /Teams meeting * Revert back to beta in main (#5742) * Revert back to beta in main * Change files * Fixed pipeline failure * Revert tags * Upload api file --------- Co-authored-by: Chukwuebuka Nwankwo <nwankwojustin93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hanged
What
When together mode is started, the stream spinner keeps spinning until the views are changed.
Why
This pr fixes the issue by ensuring the isAvailable flag is set to true first before trying to create the stream. Pr also ensures together mode component (not layout) is only rendered when together mode is started
How Tested
locally
Process & policy checklist
Is this a breaking change?