Revert "specific usePropsFor to treeshake out unncessary calling/chat code"#5728
Merged
vhuseinova-msft merged 1 commit intomainfrom Mar 20, 2025
Merged
Conversation
… code (#…" This reverts commit 33321e6.
vhuseinova-msft
requested review from
JamesBurnside,
JoshuaLai,
Leah-Xia-Microsoft,
alkwa-msft,
carocao-msft,
dmceachernmsft,
edwardlee-msft,
emlynmac,
jimchou-dev,
jpeng-ms,
mgamis-msft,
palatter,
prabhjot-msft and
waynemo
vhuseinova-msft
added
breaking-change
does not need changelog
dmceachernmsft
approved these changes
Mar 20, 2025
Mohtasim
approved these changes
Mar 20, 2025
Contributor
CallWithChat bundle size is not changed.
|
Contributor
Calling bundle size is not changed.
|
Contributor
Chat bundle size is not changed.
|
Contributor
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jqesfvngec.chromatic.com/ |
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
vhuseinova-msft
deleted the
revert-5684-alkwa/create-modality-specific-selectors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5684