Skip to content

Update Changelog to include changes for storybook #5731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carocao-msft merged 6 commits into from
Mar 28, 2025
Merged

Update Changelog to include changes for storybook #5731

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd68007
Update
carocao-msft Mar 24, 2025
69056a0
Disallow "none" change type in changelog
carocao-msft Mar 24, 2025
32be3b6
Merge branch 'main' into carocao/StorybookChangelog
carocao-msft Mar 24, 2025
357cceb
Update change type to minor in JSON
carocao-msft Mar 26, 2025
b47f46e
Merge branch 'main' into carocao/StorybookChangelog
carocao-msft Mar 27, 2025
cf43e77
Merge branch 'main' into carocao/StorybookChangelog
carocao-msft Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-6d0bac59-3894-4586-aaa0-ee9b817fcee7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
Copy link
Copy Markdown
Member

@vhuseinova-msft vhuseinova-msft Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be updated too? (as we don't support none type anymore)

Copy link
Copy Markdown
Contributor Author

@carocao-msft carocao-msft Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

"area": "storybook",
"workstream": "Update changelog to include storybook related changes",
"comment": "Update changelog to include storybook related changes",
"packageName": "@azure/communication-react",
"email": "96077406+carocao-msft@users.noreply.github.com",
"dependentChangeType": "none"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-6d0bac59-3894-4586-aaa0-ee9b817fcee7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "none",
"area": "storybook",
"workstream": "Update changelog to include storybook related changes",
"comment": "Update changelog to include storybook related changes",
"packageName": "@azure/communication-react",
"email": "96077406+carocao-msft@users.noreply.github.com",
"dependentChangeType": "none"
}
1 change: 1 addition & 0 deletions common/config/beachball/changelog-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const config: BeachballConfig = {
{ value: 'fix', title: 'Bug fix' },
{ value: 'feature', title: 'Feature' },
{ value: 'improvement', title: 'Improvement' },
{ value: 'storybook', title: 'Storybook' },
],
};
const workstreamPrompt = {
Expand Down
5 changes: 5 additions & 0 deletions common/config/beachball/changelog-custom-renders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ export async function renderPackageChangelog(renderInfo: PackageChangelogRenderI
let features: ChangelogEntry[] = [];
let improvements: ChangelogEntry[] = [];
let bugs: ChangelogEntry[] = [];
let storybookChanges: ChangelogEntry[] = [];
let unknowns: ChangelogEntry[] = [];

changelog = renderHeader(renderInfo) + '\n\n';
Expand All @@ -64,6 +65,7 @@ export async function renderPackageChangelog(renderInfo: PackageChangelogRenderI
features = features.concat(filterByArea(entries, 'feature'));
improvements = improvements.concat(filterByArea(entries, 'improvement'));
bugs = bugs.concat(filterByArea(entries, 'fix'));
storybookChanges = storybookChanges.concat(filterByArea(entries, 'storybook'));
unknowns = unknowns.concat(filterUnknown(entries));
}
}
Expand All @@ -77,6 +79,9 @@ export async function renderPackageChangelog(renderInfo: PackageChangelogRenderI
if (bugs.length > 0) {
changelog += await renderSubsection('Bug Fixes', bugs);
}
if (storybookChanges.length > 0) {
changelog += await renderSubsection('Storybook Changes', storybookChanges);
}
if (unknowns.length > 0) {
changelog += await renderSubsection('Other Changes', unknowns);
}
Expand Down
⚡