Skip to content

Update axios to 1.8.4#5732

Merged
jimchou-dev merged 4 commits intomainfrom
jimchou/update-axios-1.8.4
Mar 24, 2025
Merged

Update axios to 1.8.4#5732
jimchou-dev merged 4 commits intomainfrom
jimchou/update-axios-1.8.4

Conversation

@jimchou-dev
Copy link
Copy Markdown
Member

@jimchou-dev jimchou-dev commented Mar 24, 2025

What

  • Update axios to 1.8.4
  • Reference PR but remove old version reference from pnpm-lock.yaml

Why

  • Component govenerance / dependencybot

Fixes https://github.com/Azure/communication-ui-library/security/dependabot/304
Fixes https://github.com/Azure/communication-ui-library/security/dependabot/307

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58481 / 94462
61.9%
58481 / 94462
61.9%
1180 / 2698
43.73%
3524 / 5828
60.46%
Current 58477 / 94462
61.9%
58477 / 94462
61.9%
1180 / 2698
43.73%
3550 / 5840
60.78%
Diff -4 / 0
0%
-4 / 0
0%
0 / 0
0%
26 / 12
0.32%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29305 / 45995
63.71%
29305 / 45995
63.71%
808 / 1476
54.74%
2410 / 3825
63%
Current 29241 / 45995
63.57%
29241 / 45995
63.57%
808 / 1476
54.74%
2406 / 3816
63.05%
Diff -64 / 0
-0.14%
-64 / 0
-0.14%
0 / 0
0%
-4 / -9
0.05%

@JamesBurnside
Copy link
Copy Markdown
Member

The whole lock file has regenerated which will cause a lot of PR noise (I see fluent has updated in the lockfile which always is a pain to upgrade), you'll want to only update the axios package

@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is increased❗.

  • Current size: 1775230
  • Base size: 1775227
  • Diff size: 3

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is not changed.

  • Current size: 12401036
  • Base size: 12401036
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401048
  • Base size: 12401048
  • Diff size: 0

@jimchou-dev jimchou-dev merged commit c64bc59 into main Mar 24, 2025
40 checks passed
@jimchou-dev jimchou-dev deleted the jimchou/update-axios-1.8.4 branch March 24, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

does not need changelog Changes that does not affect the published package in any way do not need changelog entry significant bundle size change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants