Skip to content

Revert a11y dropdown group announcement#5856

Merged
edwardlee-msft merged 1 commit intomainfrom
elee/revert-a11y-dropdown-group-announcement-fix
May 21, 2025
Merged

Revert a11y dropdown group announcement#5856
edwardlee-msft merged 1 commit intomainfrom
elee/revert-a11y-dropdown-group-announcement-fix

Conversation

@edwardlee-msft
Copy link
Copy Markdown
Contributor

What

Revert a11y dropdown group announcement

Why

Causing a ghost element to take precedence when selecting a new item in the dropdown every other time.

How Tested

MacOS Chrome

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@edwardlee-msft edwardlee-msft requested review from a team as code owners May 21, 2025 16:23
@edwardlee-msft edwardlee-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label May 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Chat bundle size is not changed.

  • Current size: 1778342
  • Base size: 1778342
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12413574
  • Base size: 12413574
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

Calling bundle size is not changed.

  • Current size: 12413560
  • Base size: 12413560
  • Diff size: 0

@github-actions
Copy link
Copy Markdown
Contributor

@edwardlee-msft edwardlee-msft changed the title Revert a11y dropdwon group announcement Revert a11y dropdown group announcement May 21, 2025
@edwardlee-msft edwardlee-msft enabled auto-merge (squash) May 21, 2025 16:31
@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29499 / 47062
62.68%
29499 / 47062
62.68%
815 / 1491
54.66%
2417 / 3847
62.82%
Current 29497 / 47062
62.67%
29497 / 47062
62.67%
815 / 1491
54.66%
2416 / 3846
62.81%
Diff -2 / 0
-0.01%
-2 / 0
-0.01%
0 / 0
0%
-1 / -1
-0.01%

@github-actions
Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58551 / 94864
61.72%
58551 / 94864
61.72%
1186 / 2715
43.68%
3373 / 5769
58.46%
Current 58547 / 94844
61.72%
58547 / 94844
61.72%
1186 / 2714
43.69%
3372 / 5768
58.46%
Diff -4 / -20
0%
-4 / -20
0%
0 / -1
0.01%
-1 / -1
0%

@edwardlee-msft edwardlee-msft merged commit 3234740 into main May 21, 2025
54 of 74 checks passed
@edwardlee-msft edwardlee-msft deleted the elee/revert-a11y-dropdown-group-announcement-fix branch May 21, 2025 16:37
edwardlee-msft added a commit that referenced this pull request May 21, 2025
* Revert a11y dropdwon group announcement (#5856)

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

does not need changelog Changes that does not affect the published package in any way do not need changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants