Skip to content

Fix for dark text for raise hand button in dark theme #5877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prabhjot-msft merged 2 commits into from
Jun 4, 2025
Merged

Fix for dark text for raise hand button in dark theme #5877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6774ae
Dark text for raise hand button in dark theme
prabhjot-msft Jun 4, 2025
f439807
Change files
prabhjot-msft Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change-beta/@azure-communication-react-acd9ca3e-b6a3-45ae-be9e-3f99f4986602.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Dark text for raise hand button in dark theme",
"comment": "Dark text for raise hand button in dark theme",
"packageName": "@azure/communication-react",
"email": "97124699+prabhjot-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
9 changes: 9 additions & 0 deletions change/@azure-communication-react-acd9ca3e-b6a3-45ae-be9e-3f99f4986602.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "patch",
"area": "fix",
"workstream": "Dark text for raise hand button in dark theme",
"comment": "Dark text for raise hand button in dark theme",
"packageName": "@azure/communication-react",
"email": "97124699+prabhjot-msft@users.noreply.github.com",
"dependentChangeType": "patch"
}
26 changes: 19 additions & 7 deletions packages/react-components/src/components/RaiseHandButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,26 @@ export const RaiseHandButton = (props: RaiseHandButtonProps): JSX.Element => {

const raiseHandButtonStyles = (theme: Theme): IButtonStyles => ({
rootChecked: {
background: theme.palette.themePrimary,
color: DefaultPalette.white,
':focus::after': { outlineColor: `${DefaultPalette.white}` }
background: theme.semanticColors.primaryButtonBackground,
color: theme.semanticColors.primaryButtonText,
':focus::after': { outlineColor: `${DefaultPalette.white} !important` }, // added !important to avoid override by FluentUI button styles
'@media (forced-colors: active)': {
border: '1px solid',
borderColor: theme.palette.black
}
},
rootCheckedHovered: {
background: theme.palette.themePrimary,
color: DefaultPalette.white,
':focus::after': { outlineColor: `${DefaultPalette.white}` }
background: theme.semanticColors.primaryButtonBackgroundHovered,
color: theme.semanticColors.primaryButtonTextHovered,
':focus::after': { outlineColor: `${DefaultPalette.white} !important` }, // added !important to avoid override by FluentUI button styles
'@media (forced-colors: active)': {
border: '1px solid',
borderColor: theme.palette.black
}
},
labelChecked: { color: DefaultPalette.white }
rootCheckedPressed: {
background: theme.semanticColors.primaryButtonBackgroundPressed,
color: theme.semanticColors.primaryButtonTextPressed
},
labelChecked: { color: theme.semanticColors.primaryButtonText }
});
Loading
⚡