Skip to content

[A11y] Fix people pane navigation for people button#6029

Merged
dmceachernmsft merged 4 commits intomainfrom
dmceachernmsft/people-button-a11y-dismiss
Dec 22, 2025
Merged

[A11y] Fix people pane navigation for people button#6029
dmceachernmsft merged 4 commits intomainfrom
dmceachernmsft/people-button-a11y-dismiss

Conversation

@dmceachernmsft
Copy link
Copy Markdown
Member

What

Update the calculation of when the chat button is present and fix prevent default behavior to allow for the focus to work.

Why

Allows the developer to have better navigation to the close button after opening the people pane

https://skype.visualstudio.com/SPOOL/_workitems/edit/4322346

How Tested

Validated locally

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29739 / 47381
62.76%
29739 / 47381
62.76%
810 / 1491
54.32%
2394 / 3842
62.31%
Current 29740 / 47405
62.73%
29740 / 47405
62.73%
810 / 1491
54.32%
2394 / 3842
62.31%
Diff 1 / 24
-0.03%
1 / 24
-0.03%
0 / 0
0%
0 / 0
0%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 12, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58580 / 95109
61.59%
58580 / 95109
61.59%
1180 / 2709
43.55%
3417 / 5799
58.92%
Current 58602 / 95168
61.57%
58602 / 95168
61.57%
1180 / 2709
43.55%
3419 / 5802
58.92%
Diff 22 / 59
-0.02%
22 / 59
-0.02%
0 / 0
0%
2 / 3
0%

@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) December 17, 2025 19:17
@github-actions
Copy link
Copy Markdown
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions
Copy link
Copy Markdown
Contributor

@dmceachernmsft dmceachernmsft added the update_snapshots Set this label to request automated update of UI snapshots label Dec 22, 2025
@github-actions github-actions Bot removed the update_snapshots Set this label to request automated update of UI snapshots label Dec 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6767681 6768619 ⚠️ increased 938
580.bundle.js 12407925 12407925 ➖ unchanged 0

Total change: +938 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 7758336 7759301 ⚠️ increased 965
450.bundle.js 4470 4470 ➖ unchanged 0
580.bundle.js 12407938 12407938 ➖ unchanged 0
727.bundle.js 372564 372564 ➖ unchanged 0
82.bundle.js 28177 28155 ⬇️ decreased -22
91.bundle.js 4118 4118 ➖ unchanged 0

Total change: +943 B ⚠️

@github-actions
Copy link
Copy Markdown
Contributor

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1793916 1793884 ⬇️ decreased -32
398.bundle.js 375829 375829 ➖ unchanged 0
450.bundle.js 4454 4454 ➖ unchanged 0
82.bundle.js 28161 28139 ⬇️ decreased -22
91.bundle.js 4102 4102 ➖ unchanged 0

Total change: -54 B ⬇️

@dmceachernmsft dmceachernmsft merged commit e644b59 into main Dec 22, 2025
95 of 96 checks passed
@dmceachernmsft dmceachernmsft deleted the dmceachernmsft/people-button-a11y-dismiss branch December 22, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants