Allow taints for default (system) pool

[ealasgarov]

Currently it's not possible to taint System pool (default agent's pool) within the module.

Please allow for the parameter: [only_critical_addons_enabled = bool] or at least just a taint block to be added, e.g.

agent_taints = [
"CriticalAddonsOnly=true:NoSchedule"
]

Existing nodepools cannot be tainted after creation, only the single nodes within them.

[carvido1]

Hello.
We are facing the same problem. It would be nice to taint the nodepools directly with the cluster creation.
This is a recommendation from Microsoft documentation when using (user and system nodepools)[https://docs.microsoft.com/en-us/azure/aks/use-system-pools#system-and-user-node-pools]

Otherwise we need to taint the nodepool after creation.

az aks nodepool update --node-taint CriticalAddonsOnly=true:NoSchedule -g RG --cluster-name AKS-CLUSTER -n system

KR

[lonegunmanb]

Hi @ealasgarov , unfortunately as I've explained in #163:

The AKS API has removed support for tainting all nodes in the default node pool and it is no longer possible to configure this. To taint a node pool, create a separate one.

So I think it's impossible to taint the default node pool. Thanks for opening this issue.

[terrymunro]

@lonegunmanb What about that parameter @ealasgarov mentioned: kubernetes_cluster#only_critical_addons_enabled

It is strange that the error message says it's been removed but then a few lines later it adds one in anyway.
Is that one an exception, a bug, or lies? 🤷

[lonegunmanb]

Sorry @terrymunro for this crazy late reply, we just barely solved almost all the remaining pull requests due to lack of manpower. The only_critical_addons_enabled was introduced to this module in #129 , please use this variable. Thank you all for your understanding.

[lonegunmanb]

I'm closing this issue since we can taint default node pool since #129 introduced new variable only_critical_addons_enabled.