Include node_resource_group as variable#136
Conversation
|
|
|
It would also be useful for us to have this PR approved, we are using this module in a context where we have resource group name constrainments and not being able to customise it is a bit problematic. |
|
Like @andypanix said, please merge this feature, otherwise we have a messed up naming convention. |
|
Hey reviewers folks, can this be approved please ? |
|
Hi @sbl-matter You agreed that the change is needed. Can you please approve again, or add someone with the right permissions to do so, as you're assigned as reviewer and the PR can finally be merged. We would really appreciate it. Thanks in advance. |
|
Sorry @shurik-io , i reviewed, as I think you could do too, thinking that would speed up the process but apparently only somebody with write access can do anything. |
sbl-matter
left a comment
sbl-matter
left a comment
There was a problem hiding this comment.
This merge would me much appreciated
@sbl-matter can you ping someone with write access to have a look and approve it, as I don't know who could do it. Thanks in advance. |
|
@lonegunmanb |
|
Can this be merged? :) |
|
Can this be picked up as well? Thanks |
|
Yes, please waiting for this to be merged |
| } | ||
|
|
||
| variable "node_resource_group" { | ||
| description = "The auto-generated Resource Group which contains the resources for this Managed Kubernetes Cluster." |
There was a problem hiding this comment.
Would the description " (Optional) The name of the Resource Group where the Kubernetes Nodes should exist. Changing this forces a new resource to be created." be better?
|
@lonegunmanb thanks for merging the PR, it would be great now if a new release would be available, could you publish the 4.15.0 release? Many thanks! |
|
Hi @andypanix , this feature has been released as 4.15.0. |
10 participants
This PR close #135