Skip to content

support-for-publicDNS-for-privateAKScluster : adding private_dns_zone_id & private_cluster_public_fqdn_enabled vars to control private aks cluster#149

Merged
lonegunmanb merged 8 commits intoAzure:masterfrom
iamamitgera:master
Jul 13, 2022
Merged

support-for-publicDNS-for-privateAKScluster : adding private_dns_zone_id & private_cluster_public_fqdn_enabled vars to control private aks cluster#149
lonegunmanb merged 8 commits intoAzure:masterfrom
iamamitgera:master

Conversation

@iamamitgera
Copy link
Copy Markdown
Contributor

@iamamitgera iamamitgera commented Mar 22, 2022

Fixes #000

Changes proposed in the pull request:

Amit Gera and others added 2 commits March 22, 2022 13:19
adding private_dns_zone_id & private_cluster_public_fqdn_enabled vars…
8aa1f30 
… to control private aks cluster
@iamamitgera
Merge pull request #1 from iamamitgera/support-for-publicDNS-for-priv…
fa0885d 
…ateAKScluster

support-for-publicDNS-for-privateAKScluster : adding private_dns_zone_id & private_cluster_public_fqdn_enabled vars to control private aks cluster
@ghost
Copy link
Copy Markdown

ghost commented Mar 22, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@stephane-pham-shift
Copy link
Copy Markdown

stephane-pham-shift commented Apr 13, 2022

Hello,
I have the same requirement.
When can we change it?

lonegunmanb
lonegunmanb requested changes May 18, 2022
View reviewed changes
Comment thread main.tf
@ghost
Copy link
Copy Markdown

ghost commented Jun 21, 2022

Any news on when this will be merged?

@lonegunmanb
Copy link
Copy Markdown
Member

lonegunmanb commented Jun 22, 2022

Hi @liechtinat thanks for asking, for now this pr has a tiny format issue. I'd like to wait for @iamamitgera to fix that as he or she is the author, but if you're in a hurry maybe I can submit a new pr based on his to add this feature.

@ghost
Copy link
Copy Markdown

ghost commented Jun 22, 2022

That would be cool, we currently have a fork of the repo to mitigate this issue as we want to use public resolvable kubeapi records for our private AKS clusters. I can also submit the PR if needed.

@iamamitgera
Copy link
Copy Markdown
Contributor Author

iamamitgera commented Jun 29, 2022

I am regretful for delay as was occupied somewhere , I will get this done by tomorrow with requested changes

@the-technat
Copy link
Copy Markdown
Contributor

the-technat commented Jun 29, 2022

Looks like terraform fmt was run. Anything that prevents this from merging?

the-technat
the-technat approved these changes Jul 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@the-technat the-technat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lonegunmanb
lonegunmanb requested changes Jul 8, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iamamitgera , almost LGTM but only two tiny description issues.

Comment thread variables.tf Outdated
Comment thread variables.tf Outdated
@the-technat
Copy link
Copy Markdown
Contributor

the-technat commented Jul 8, 2022 •
edited
Loading

@iamamitgera would you mind resolving the description issues?

@mkilchhofer
Copy link
Copy Markdown
Contributor

mkilchhofer commented Jul 12, 2022

@lonegunmanb can we merge this? We can file a PR to fix the quotation if needed but it looks kinda weird to wait on a contributor to fix quotes.

@iamamitgera iamamitgera requested a review from lonegunmanb July 12, 2022 20:05
lonegunmanb
lonegunmanb approved these changes Jul 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iamamitgera , LGTM!

@lonegunmanb lonegunmanb merged commit 577db7d into Azure:master Jul 13, 2022
@mkilchhofer
Copy link
Copy Markdown
Contributor

mkilchhofer commented Jul 13, 2022

🥳 nice.
When do we have this released?

@zioproto zioproto mentioned this pull request Jul 13, 2022
Merged
@lonegunmanb lonegunmanb mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonegunmanb lonegunmanb lonegunmanb approved these changes

+2 more reviewers

@mkilchhofer mkilchhofer mkilchhofer approved these changes

@the-technat the-technat the-technat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iamamitgera @stephane-pham-shift @lonegunmanb @the-technat @mkilchhofer
⚡