workaround for recreate bug#172
Merged
lonegunmanb merged 3 commits intoAzure:masterfrom Jun 7, 2022
Merged
Conversation
|
|
lonegunmanb
approved these changes
Jun 7, 2022
Member
|
Thanks @davidkarlsen , LGTM. |
This was referenced Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in the pull request:
This allows to define
locationfor the resources explicitly. Because if you have slight diffs on the resource group (like for instance a label being propagated by a mitigating policy), then terraform will say that thelocationis only known after apply, and this will again trigger a recreate on the cluster - blowing the whole cluster away.The change is backwards-compatible, as the new parameter is opt-in, and old behaviour of reading location from resource-group is preserved.