Skip to content

fix output addon_profile not supported in provider 3.10.0#179

Closed
zioproto wants to merge 1 commit intoAzure:masterfrom
zioproto:provider-3.10.0-fixes
Closed

fix output addon_profile not supported in provider 3.10.0#179
zioproto wants to merge 1 commit intoAzure:masterfrom
zioproto:provider-3.10.0-fixes

Conversation

@zioproto
Copy link
Copy Markdown
Contributor

The addon_profile has been removed in this version of the provider:

https://github.com/hashicorp/terraform-provider-azurerm/blob/main/website/docs/guides/3.0-upgrade-guide.html.markdown#data-source-azurerm_kubernetes_cluster

Tested with provider version 3.10.0

terraform {
  required_providers {
    azurerm = {
      source  = "hashicorp/azurerm"
      version = "~> 3.10.0"
    }
  }

  required_version = ">= 1.1.0"
}

Fixes the following failure:

 Error: Unsupported attribute
│
│   on .terraform/modules/aks/outputs.tf line 91, in output "addon_profile":
│   91:   value = try(azurerm_kubernetes_cluster.main.addon_profile.0, null)
│
│ This object has no argument, nested block, or exported attribute named "addon_profile".

@zioproto zioproto force-pushed the provider-3.10.0-fixes branch from 34c3211 to a56a231 Compare June 17, 2022 12:59
@lonegunmanb
Copy link
Copy Markdown
Member

Thanks @zioproto for opening this pr. The addon_profile is an object containing multiple sub arguments including http_application_routing_enabled and azure_policy_enabled. Would a new object type addon_profile in the output file be better so we can save effort for the users who're using this object.

Since the incoming new tag version will be a major version upgrade, I'm working on refactor the code with some breaking changes too. I'll submit my pr next week, may I ask for your review then? Thanks!

@zioproto
Copy link
Copy Markdown
Contributor Author

@lonegunmanb OK for me. Please assign to me the new PR for review and I will close this one. Thanks

@zioproto zioproto force-pushed the provider-3.10.0-fixes branch from a56a231 to c953be9 Compare June 20, 2022 11:55
@puru45
Copy link
Copy Markdown

puru45 commented Jul 4, 2022

It seems addon_profile already got deprecated from the version 3.x.x. So, I need an example syntax for these ingress_application_gateway, key_vault_secrets_provider and aci_connector_linux, kube_dashboard blocks.

Please share me those, thanks

@zioproto
Copy link
Copy Markdown
Contributor Author

zioproto commented Jul 5, 2022

@puru45 please look into PR #188 that deprecates this PR. I am going to close this one without merging because PR #188 takes care of this.

@zioproto zioproto closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants