Remove deprecated variable enable_kube_dashboard#187
Merged
lonegunmanb merged 2 commits intoAzure:masterfrom Jun 22, 2022
Merged
Remove deprecated variable enable_kube_dashboard#187lonegunmanb merged 2 commits intoAzure:masterfrom
enable_kube_dashboard#187lonegunmanb merged 2 commits intoAzure:masterfrom
Conversation
Member
Author
|
Hi @davidkarlsen , I'll submit some prs, would you please give them code review before merge? Thanks! |
Contributor
Sure, I'm no maintainer, but I can have a look. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr remove deprecated variable
enable_kube_dashboardas #181 described. It also updated the readme file.This pr rely on pr #188 since the removed
addon_blockwill block the test code.