Uses Azure policies add-on in the test fixture code#203
Merged
lonegunmanb merged 2 commits intoAzure:masterfrom Jul 7, 2022
Merged
Uses Azure policies add-on in the test fixture code#203lonegunmanb merged 2 commits intoAzure:masterfrom
lonegunmanb merged 2 commits intoAzure:masterfrom
Conversation
zioproto
reviewed
Jun 29, 2022
| @@ -40,7 +40,7 @@ module "aks" { | |||
| vnet_subnet_id = azurerm_subnet.test.id | |||
| os_disk_size_gb = 60 | |||
| enable_http_application_routing = true | |||
Contributor
There was a problem hiding this comment.
There are many "enable" variables that have the wrong naming convention. Does it makes sense to fix all the variables in a single PR ?
Member
Author
There was a problem hiding this comment.
Thanks for the tip, I think this is a special case since it's related to is single pr.
I agree with you, we need a single pr to fix all these enable_xxx variables.
…t the naming convention. Set `azure_policy_enabled` to true in test fixture code.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
var.enable_azure_policytovar.azure_policy_enabledto meet the naming convention.Set
azure_policy_enabledto true in test fixture code.Related to #202 and #183