[Breaking] Remove unused net_profile_docker_bridge_cidr

[zioproto]

Since 2020 the default runtime is containerd and not Docker
https://github.com/Azure/AKS/blob/master/CHANGELOG.md#release-2020-06-29

The setting docker_bridge_cidr is doing nothing.
If you check the interfaces on the AKS nodes they dont have any Docker bridge configured.

Fixes #122

[zioproto]

This can't be removed so easily 😭
from the docs:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster

[zioproto]

This PR is currently blocked by hashicorp/terraform-provider-azurerm#18119

After the issue in the azurerm provider is closed, it is possible to finish this PR

[lonegunmanb]

This PR is currently blocked by hashicorp/terraform-provider-azurerm#18119

After the issue in the azurerm provider is closed, it is possible to finish this PR

Removing an argument from Terraform Provider will be considered as a breaking change, so it won't be implemented until 4.0, which I believe will be in next year.

[zioproto]

this PR should work once hashicorp/terraform-provider-azurerm#20952 is released in the provider

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/pr-check.yaml:prepr-check. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

[github-actions]

Potential Breaking Changes in e3e36b4:
[delete] "Variables.net_profile_docker_bridge_cidr.Name" from 'net_profile_docker_bridge_cidr' to ''

[zioproto]

as per hashicorp/terraform-provider-azurerm#18119 the provider change is available in provider version v3.49.0

[lonegunmanb]

Hi @zioproto, I think it's time to merge this pr in 7.0.0, would you please rebase your branch with the latest main branch and commit again? Thanks!

[github-actions]

Potential Breaking Changes in 383f6e4:
[delete] "Variables.net_profile_docker_bridge_cidr.Name" from 'net_profile_docker_bridge_cidr' to ''

[lonegunmanb]

Thanks @zioproto, LGTM! 🚀