Output Kubernetes Cluster Name#234
Merged
lonegunmanb merged 3 commits intoAzure:masterfrom Aug 31, 2022
Merged
Conversation
|
|
vermacodes
added a commit
to vermacodes/one-click-aks
that referenced
this pull request
Aug 24, 2022
- This change is proposed on the upstrem project and can be enabled only after its merged. PR Azure/terraform-azurerm-aks#234
Contributor
Author
|
Hello @lonegunmanb Any thoughts on this PR? |
lonegunmanb
requested changes
Aug 29, 2022
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Almost LGTM but a tiny change request, thanks for your pr!
Add '.' in the description of output aks_name
lonegunmanb
approved these changes
Aug 31, 2022
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution @vermacodes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #233
Changes proposed in the pull request:
Output name of the Kubernetes cluster