Skip to content

bugfix: Make the Azure Defender clause robust against a non-existent … #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lonegunmanb merged 20 commits into from
Sep 30, 2022
Merged

bugfix: Make the Azure Defender clause robust against a non-existent … #258

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
32472bc
bugfix: Make the Azure Defender clause robust against a non-existent …
gzur Sep 27, 2022
8ac6c72
Merge branch 'master' of github.com:Azure/terraform-azurerm-aks into …
gzur Sep 28, 2022
58caf97
Leverage the terraform `locals` clause to unify analytics workspace l…
gzur Sep 28, 2022
9d06fa5
Ensure the existence of an analytics workspace enabling Microsoft Def…
gzur Sep 28, 2022
5fe6e64
terraform fmt
gzur Sep 28, 2022
7fbe2ed
Update docs to state that Microsoft Defender requires an Analytics Wo…
gzur Sep 28, 2022
eaab22d
Add link to analytics workspace var to defender var docs
gzur Sep 28, 2022
45e04d3
Close parentheses
gzur Sep 28, 2022
cd498f6
Merge branch 'Azure:master' into fix-disabled-log_analytics_workspace
gzur Sep 28, 2022
fb7f810
Respond to comments
gzur Sep 29, 2022
05ff54e
Apply changes made by automation suite
gzur Sep 29, 2022
f10a149
Remove unused variable. I
gzur Sep 29, 2022
38ac6d3
Revert "Remove unused variable."
gzur Sep 29, 2022
f393026
Instruct tflint to ignore unused variable
gzur Sep 29, 2022
63ffe5b
cleanup
gzur Sep 29, 2022
ae9e5d1
Refactor the Defender precondition expression
gzur Sep 29, 2022
4fde09a
Re-introduce `log_analytics_solution_id`
gzur Sep 29, 2022
19e15ed
Merge branch 'master' of github.com:Azure/terraform-azurerm-aks into …
gzur Sep 30, 2022
e2c9204
Re-introduce autogenerated documentation after merge
gzur Sep 30, 2022
e3016f2
Add control local variable for whether to create an analytics solutio…
gzur Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ resource "azurerm_kubernetes_cluster" "main" {
for_each = var.microsoft_defender_enabled ? ["microsoft_defender"] : []

content {
log_analytics_workspace_id = coalesce(try(var.log_analytics_workspace.id, null), azurerm_log_analytics_workspace.main[0].id)
log_analytics_workspace_id = coalesce(try(var.log_analytics_workspace.id, null), try(azurerm_log_analytics_workspace.main[0].id, null))
}
}
network_profile {
Expand Down
⚡