Skip to content

[Breaking] Wrap log_analytics_solution_id to an object to fix #263.#265

Merged
jiaweitao001 merged 2 commits intoAzure:mainfrom
lonegunmanb:f-263
Apr 12, 2023
Merged

[Breaking] Wrap log_analytics_solution_id to an object to fix #263.#265
jiaweitao001 merged 2 commits intoAzure:mainfrom
lonegunmanb:f-263

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Wrap log_analytics_solution_id to an object to fix #263.
This pr also added symbolic links notice in the readme.

@github-actions
Copy link
Copy Markdown
Contributor

Potential Breaking Changes in 16eff1f:
[delete] "Variables.log_analytics_solution_id.Name" from 'log_analytics_solution_id' to ''

@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@Azure Azure deleted a comment from github-actions Bot Apr 10, 2023
@lonegunmanb lonegunmanb changed the title Wrap log_analytics_solution_id to an object to fix #263. [Breaking] Wrap log_analytics_solution_id to an object to fix #263. Apr 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Potential Breaking Changes in f48b3ad:
[delete] "Variables.log_analytics_solution_id.Name" from 'log_analytics_solution_id' to ''

lonegunmanb and others added 2 commits April 11, 2023 14:02
@lonegunmanb lonegunmanb temporarily deployed to acctests April 11, 2023 06:15 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@jiaweitao001 jiaweitao001 merged commit 235c61c into Azure:main Apr 12, 2023
@lonegunmanb lonegunmanb deleted the f-263 branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wraping var.log_analytics_solution_id with an object so we can create an azurerm_log_analytics_solution outside this module and pass id as a variable.

2 participants