Skip to content

Upgrade terraform-module-test-helper lib so we can get rid of override file to execute version upgrade test#279

Merged
jiaweitao001 merged 1 commit intoAzure:masterfrom
lonegunmanb:no-override
Dec 7, 2022
Merged

Upgrade terraform-module-test-helper lib so we can get rid of override file to execute version upgrade test#279
jiaweitao001 merged 1 commit intoAzure:masterfrom
lonegunmanb:no-override

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Describe your changes

For now we need to put an override.tf.tplt file for every example folder to execute version upgrade test, because we use Terraform override file to modify module's source. Now we've upgrade terraform-module-test-helper lib, it can modify the hcl file directly to redirect the module's source.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests December 2, 2022 10:13 Inactive
Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@jiaweitao001 jiaweitao001 merged commit ff54e95 into Azure:master Dec 7, 2022
@lonegunmanb lonegunmanb deleted the no-override branch November 21, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants