Add support for default node pool's node_taints#300
Merged
lonegunmanb merged 2 commits intoAzure:mainfrom Feb 13, 2023
Merged
Conversation
|
Shouldn't the default be I'm observing the following plan changes (Terraform 1.3.7, hashicorp/azurerm 3.43.0, AKS K8s 1.25.5): |
Member
Author
|
Thanks for asking @mloskot, for this argument I've checked the schema definition in AzureRM provider: "node_taints": {
Type: pluginsdk.TypeList,
ForceNew: true,
Optional: true,
Elem: &pluginsdk.Schema{
Type: pluginsdk.TypeString,
},
},
|
|
@lonegunmanb Thanks for the explanation and suggestions. I'll try it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pr added support for
default_node_pool.node_taintsargument.Issue number
#299
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!