Skip to content

Fix example multiple_node_pools#328

Merged
jiaweitao001 merged 2 commits intoAzure:mainfrom
lonegunmanb:f-multiple_node_pools
Mar 21, 2023
Merged

Fix example multiple_node_pools#328
jiaweitao001 merged 2 commits intoAzure:mainfrom
lonegunmanb:f-multiple_node_pools

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb commented Mar 20, 2023

Describe your changes

The multiple_node_pools example failed the test because we didn't set vnet_subnet_id. This pr fixed this issue.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests March 20, 2023 06:30 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests March 20, 2023 08:59 — with GitHub Actions Inactive
@github-advanced-security
Copy link
Copy Markdown

github-advanced-security AI commented Mar 20, 2023

You have successfully added a new CodeQL configuration .github/workflows/pr-check.yaml:prepr-check. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

jiaweitao001
jiaweitao001 approved these changes Mar 21, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jiaweitao001 jiaweitao001 merged commit f27f095 into Azure:main Mar 21, 2023
@lonegunmanb lonegunmanb mentioned this pull request Mar 21, 2023
Merged
3 tasks
@lonegunmanb lonegunmanb deleted the f-multiple_node_pools branch June 30, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lonegunmanb @github-advanced-security @jiaweitao001
⚡