Skip to content

Add support for monitor_metrics#341

Merged
lonegunmanb merged 1 commit intoAzure:mainfrom
zioproto:feature/monitor-metrics
Apr 4, 2023
Merged

Add support for monitor_metrics#341
lonegunmanb merged 1 commit intoAzure:mainfrom
zioproto:feature/monitor-metrics

Conversation

@zioproto
Copy link
Copy Markdown
Contributor

Add support for monitor_metrics

https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/kubernetes_cluster#monitor_metrics

Issue number

#340

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

@github-advanced-security
Copy link
Copy Markdown

You have successfully added a new CodeQL configuration .github/workflows/pr-check.yaml:prepr-check. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@zioproto zioproto force-pushed the feature/monitor-metrics branch from 3159e50 to 680acd1 Compare March 30, 2023 13:24
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zioproto for opening this pr! One comment.

Comment thread variables.tf Outdated
@zioproto zioproto force-pushed the feature/monitor-metrics branch from 680acd1 to 6e7b165 Compare March 31, 2023 06:56
Comment thread variables.tf
@zioproto zioproto force-pushed the feature/monitor-metrics branch from 6e7b165 to 82c91ea Compare March 31, 2023 07:43
@zioproto zioproto temporarily deployed to acctests March 31, 2023 11:50 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb merged commit c62bcfc into Azure:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants