Skip to content

User location returned from data source for log analytics solution.#349

Merged
jiaweitao001 merged 5 commits intoAzure:mainfrom
lonegunmanb:e-344
Jun 1, 2023
Merged

User location returned from data source for log analytics solution.#349
jiaweitao001 merged 5 commits intoAzure:mainfrom
lonegunmanb:e-344

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Describe your changes

As #344 described, this module would cause an error once we'd like to deploy an aks cluster with a log analytics workspace that is located in another region.

This pr added a data source to read the workspace's location to avoid this issue. It also added a new e2e test TestExamples_differentLocationForLogAnalyticsSolution to verify it.

Issue number

#344

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb changed the title E 344 User location returned from data source for log analytics solution. Apr 12, 2023
@lonegunmanb lonegunmanb changed the title User location returned from data source for log analytics solution. [Breaking] User location returned from data source for log analytics solution. Apr 12, 2023
@lonegunmanb lonegunmanb changed the title [Breaking] User location returned from data source for log analytics solution. User location returned from data source for log analytics solution. Apr 12, 2023
@lonegunmanb lonegunmanb added this to the 7.1.0 milestone Apr 23, 2023
@lonegunmanb lonegunmanb temporarily deployed to acctests May 29, 2023 06:02 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests May 30, 2023 02:20 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jiaweitao001 jiaweitao001 merged commit c6e76a1 into Azure:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants