Skip to content

assign network contributor role to control plane identity#369

Merged
lonegunmanb merged 1 commit intoAzure:mainfrom
zioproto:fix-network-contributor-role-assignment
May 23, 2023
Merged

assign network contributor role to control plane identity#369
lonegunmanb merged 1 commit intoAzure:mainfrom
zioproto:fix-network-contributor-role-assignment

Conversation

@zioproto
Copy link
Copy Markdown
Contributor

Assign network contributor role to control plane identity.

Now it is currently using the kubelet identity which is wrong.

Relevant docs:
https://learn.microsoft.com/en-us/azure/aks/use-managed-identity#summary-of-managed-identities

Fixes #368

@zioproto
Copy link
Copy Markdown
Contributor Author

@lonegunmanb please approve e2e tests

@zioproto zioproto temporarily deployed to acctests May 23, 2023 02:05 — with GitHub Actions Inactive
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zioproto, LGTM 🚀

@lonegunmanb lonegunmanb merged commit a047f32 into Azure:main May 23, 2023
@zioproto
Copy link
Copy Markdown
Contributor Author

@lonegunmanb should we create a v6.8.0 branch and cherry-pick this fix for a v6.8.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid principal id for "azurerm_role_assignment" "network_contributor"

2 participants