oidc_issuer_enabled must be set to true to enable Azure AD Worklo…#377
Merged
lonegunmanb merged 1 commit intoAzure:mainfrom May 31, 2023
Merged
Conversation
lonegunmanb
requested changes
May 26, 2023
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Hi @zioproto thanks for opening this pr, we need merge this branch to the latest main branch to get version-upgrade test work, would you please update your branch and try again? Thanks!
zioproto
force-pushed
the
precondition-workload-identity
branch
from
ab1e4aa to
9c23b45
Compare
lonegunmanb
requested changes
May 30, 2023
| error_message = "KMS etcd encryption doesn't work with system-assigned managed identity." | ||
| } | ||
| precondition { | ||
| condition = var.workload_identity_enabled ? var.oidc_issuer_enabled : true |
Member
There was a problem hiding this comment.
Could we simplify this expression to?:
condition = !var.workload_identity_enabled || var.oidc_issuer_enabled
zioproto
force-pushed
the
precondition-workload-identity
branch
from
9c23b45 to
f482eab
Compare
lonegunmanb
approved these changes
May 31, 2023
Member
lonegunmanb
left a comment
lonegunmanb
left a comment
There was a problem hiding this comment.
Thanks @zioproto for the update, LGTM! 🚀
skolobov
pushed a commit
to skolobov/terraform-azurerm-aks
that referenced
this pull request
Oct 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following error: