Skip to content

Use lonegunmanb/public-ip/lonegunmanb module to retrieve public ip#396

Merged
jiaweitao001 merged 2 commits intoAzure:mainfrom
lonegunmanb:robust-public-ip
Jun 20, 2023
Merged

Use lonegunmanb/public-ip/lonegunmanb module to retrieve public ip#396
jiaweitao001 merged 2 commits intoAzure:mainfrom
lonegunmanb:robust-public-ip

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb commented Jun 19, 2023

Describe your changes

We used to call https://api.ipify.org?format=json to retrieve our current public ip, but sometimes the API is unstable, and the returned temporary errors might break our e2e tests and cause the waste of time.

This pr improves that by calling public-ip module, the module would fetch the public IP address from three different public APIs to ensure reliability and fallback support.

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests June 19, 2023 06:20 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jiaweitao001 jiaweitao001 merged commit 8cdf6db into Azure:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants