Skip to content

Add support for workload_autoscaler_profile settings#404

Merged
lonegunmanb merged 4 commits intoAzure:mainfrom
bonddim:workload-autoscaler
Nov 22, 2023
Merged

Add support for workload_autoscaler_profile settings#404
lonegunmanb merged 4 commits intoAzure:mainfrom
bonddim:workload-autoscaler

Conversation

@bonddim
Copy link
Copy Markdown
Contributor

@bonddim bonddim commented Jul 5, 2023

Describe your changes

Add support for workload_autoscaler_profile settings by adding variables:
workload_autoscaler_profile_keda_enabled - to enable Keda Autoscaler

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

@lonegunmanb
Copy link
Copy Markdown
Member

Thanks @bonddim for opening this pr! I've checked the document, the feature seems to be a preview one, I'd like to hold this pr until the feature is GA. Thanks for your contribution and please feel free to ping me once the feature is GA.

@lonegunmanb lonegunmanb added the preview feature We won't support preview feature request since the service team could withdraw them any time label Sep 21, 2023
@samuelb
Copy link
Copy Markdown

samuelb commented Nov 20, 2023

@bonddim
Copy link
Copy Markdown
Contributor Author

bonddim commented Nov 20, 2023

KEDA is now GA: https://azure.microsoft.com/en-us/updates/ga-kubernetes-eventdriven-autoscaling-keda-addon-for-aks/

Thank you for notifying me about the update!

@bonddim
Copy link
Copy Markdown
Contributor Author

bonddim commented Nov 20, 2023

Thanks @bonddim for opening this pr! I've checked the document, the feature seems to be a preview one, I'd like to hold this pr until the feature is GA. Thanks for your contribution and please feel free to ping me once the feature is GA.

@lonegunmanb, PR is updated with latest main and removed VPA variable.

@lonegunmanb
Copy link
Copy Markdown
Member

Thanks @bonddim for opening this pr! I've checked the document, the feature seems to be a preview one, I'd like to hold this pr until the feature is GA. Thanks for your contribution and please feel free to ping me once the feature is GA.

@lonegunmanb, PR is updated with latest main and removed VPA variable.

Wow thanks for the update @bonddim @samuelb !

@lonegunmanb lonegunmanb removed the preview feature We won't support preview feature request since the service team could withdraw them any time label Nov 21, 2023
@lonegunmanb lonegunmanb added this to the 8.0.0 milestone Nov 21, 2023
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bonddim for the update.

According to the provider's schema, there're two configurable attributes in workload_autoscaler_profile block, I'd like to give this nested block a full support by this pr, would you please adjust the pr as I'v commented? Thanks!

Comment thread variables.tf Outdated
Comment thread main.tf Outdated
Copy link
Copy Markdown
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bonddim, LGTM!

@lonegunmanb lonegunmanb merged commit db799b6 into Azure:main Nov 22, 2023
@bonddim bonddim deleted the workload-autoscaler branch November 22, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants