Skip to content

Fix #405 incorrect role assignment resource#410

Merged
jiaweitao001 merged 1 commit intoAzure:mainfrom
lonegunmanb:f-405
Jul 13, 2023
Merged

Fix #405 incorrect role assignment resource#410
jiaweitao001 merged 1 commit intoAzure:mainfrom
lonegunmanb:f-405

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Fix #405 by reading user assigned identity's principal id via data source.

I cannot find a way to fix for_each issue when subnet id is Known after apply for original resource block design, so I added a new variable to grant network contribute role to cluster's identity to avoid potential for_each argument issue.

Describe your changes

Issue number

#000

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

…ta source. Add new variable to grant network contribute role to cluster's identity to avoid potential `for_each` argument issue.
@lonegunmanb lonegunmanb temporarily deployed to acctests July 12, 2023 03:09 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Network Contributor role assignment fails with UserAssigned Identity and Azure subnet

2 participants