Skip to content

Add location and resource_group_name for var.log_analytics_workspace#412

Merged
jiaweitao001 merged 6 commits intoAzure:mainfrom
lonegunmanb:f-411
Aug 3, 2023
Merged

Add location and resource_group_name for var.log_analytics_workspace#412
jiaweitao001 merged 6 commits intoAzure:mainfrom
lonegunmanb:f-411

Conversation

@lonegunmanb
Copy link
Copy Markdown
Member

Add location and resource_group_name for var.log_analytics_workspace so users can set these two fields and avoid
data.azurerm_log_analytics_workspace in case they'd like to use resource in another subscription.

Describe your changes

Issue number

#411

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

users can set these two fields and avoid
data.azurerm_log_analytics_workspace in case they'd like to use resource
in another subscription.
@github-actions
Copy link
Copy Markdown
Contributor

Potential Breaking Changes in 8fa4aad:
[update] "Variables.log_analytics_workspace.Type" from 'object({
id = string
name = string
})' to 'object({
id = string
name = string
location = optional(string)
resource_group_name = optional(string)
})'

@github-actions
Copy link
Copy Markdown
Contributor

Potential Breaking Changes in 9a24d9c:
[update] "Variables.log_analytics_workspace.Type" from 'object({
id = string
name = string
})' to 'object({
id = string
name = string
location = optional(string)
resource_group_name = optional(string)
})'

@github-actions
Copy link
Copy Markdown
Contributor

Potential Breaking Changes in 886c26d:
[update] "Variables.log_analytics_workspace.Type" from 'object({
id = string
name = string
})' to 'object({
id = string
name = string
location = optional(string)
resource_group_name = optional(string)
})'

@lonegunmanb lonegunmanb temporarily deployed to acctests July 20, 2023 06:14 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests July 28, 2023 09:46 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests August 1, 2023 03:09 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 1, 2023

Potential Breaking Changes in b771b7d:
[update] "Variables.log_analytics_workspace.Type" from 'object({
id = string
name = string
})' to 'object({
id = string
name = string
location = optional(string)
resource_group_name = optional(string)
})'

Copy link
Copy Markdown
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jiaweitao001 jiaweitao001 merged commit 0577243 into Azure:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants